The following string: search-suggestions=Search Suggestions is displayed as: - a button - a header - a label We must use 3 different strings, many locales can't properly localize this string. See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Don%27t_reuse_strings_in_different_contexts I'll provide a patch. Technically, it will break string freeze on the dashboard, but in reality it won't if we use: search-suggestions=Search Suggestions search-suggestions-button={{search-suggestions}} search-suggestions-header={{search-suggestions}} It will reuse the existing translations for search-suggestions by default, but localizers will be able to override it as they will.

Thanks for filing Théo. Feel free to assign to either Dale Harvey or myself if you'd like us to write the patch.

(In reply to Kevin Grandon :kgrandon from comment #1) > Thanks for filing Théo. Feel free to assign to either Dale Harvey or myself > if you'd like us to write the patch. Thanks Kevin! I know you guys have a bunch of work these days, I'll try to save you some time :) This one should be trivial

Comment on attachment 8441456 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20624 Nice work, Théo. It looks good to me! Please make sure all tests got passed before merging, thanks ;)

Thanks Ej Errors on https://tbpl.mozilla.org/?tree=Gaia-Try&rev=b1f9872b6134de34ce216f19458dd11c8d8201f8 seems unrelated. Note that we need to merge this one on 2.0 before Friday

Thanks guys, landed: https://github.com/mozilla-b2g/gaia/commit/6a2d8964017778accddaa3bcd45a6d10c876dfbb

v2.0: https://github.com/mozilla-b2g/gaia/commit/2a957fab14b16d9f1e5498960fe384373e889b02