Closed
Bug 1025652
Opened 10 years ago
Closed 10 years ago
Webpage not loading images, Issues with scripts
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 932198
Tracking | Status | |
---|---|---|
firefox31 | --- | unaffected |
firefox32 | + | fixed |
firefox33 | + | fixed |
People
(Reporter: ransagy, Unassigned)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140614030205
Steps to reproduce:
Navigate to http://football.secunit.org/ in Firefox nightly/trunk.
Actual results:
Should have country icon images inside the circles. Does so on IE11/Chrome 37.
Also, Dragging the circles around behaves oddly and leaves broken rendering of lines.
This also happens in IE11 to some degree, works as should in Chrome 37.
Expected results:
Country images should have loaded inside the circles.
Dragging the circles should have kept their connecting lines rendering properly with the dragging movement/new placement.
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression,
regressionwindow-wanted
OS: Windows 8.1 → All
Summary: Webpage not loading images, Issues with scripts, Works in ffbeta/IE/Chrome → Webpage not loading images, Issues with scripts
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
(In reply to Ran Sagy from comment #0)
>Should have country icon images inside the circles. Does so on IE11/Chrome 37.
I can reproduce the problem in Aurora32.0a2 and Nightly33.0a1.
> Also, Dragging the circles around behaves oddly and leaves broken rendering
> of lines.
I cannot reproduce this.
Regression Window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4511d9ac1000
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140606104153
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79624417d247
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140606104333
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4511d9ac1000&tochange=79624417d247
Regressed by: Bug 994081
Blocks: 994081
status-firefox31:
--- → unaffected
status-firefox32:
--- → affected
status-firefox33:
--- → affected
tracking-firefox32:
--- → ?
tracking-firefox33:
--- → ?
Component: Untriaged → Graphics
Keywords: regressionwindow-wanted
Product: Firefox → Core
Version: Trunk → 32 Branch
Comment 4•10 years ago
|
||
To be specific, I can reproduce the issue with the missing image in the circle. I don't see broken rendering.
Update:
Sorry, My bad there about rendering/script issue - It's actually IE that fails at this, FF Nightly and Chrome do just fine.
Comment 6•10 years ago
|
||
Updated•10 years ago
|
Attachment #8441099 -
Flags: review?(matt.woodrow)
Comment 8•10 years ago
|
||
We really want to avoid doing this. This is going to be really slow on any backend that has the pixels in VRAM (like Direct2D), and jwatt has been working hard to get rid of the callers of GetThebesSurfaceForDrawTarget.
What creates the cairo gfxContext that is used in this case? We should try just convert that location to Moz2D instead.
Comment 9•10 years ago
|
||
Had a look because I was bored, this fixes the issue for me.
Attachment #8441135 -
Flags: review?(jwatt)
Comment 10•10 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #9)
> Had a look because I was bored, this fixes the issue for me.
:( Unfortunately we already have a patch that does this in bug 932198. I've been holding off on landing it because doing this conversion breaks some reftests. Or at least it used to, but may not now after more Moz2D conversion. I'll push to Try and see if that's still the case.
Updated•10 years ago
|
Attachment #8441099 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8441135 -
Flags: review?(jwatt)
Comment 11•10 years ago
|
||
I landed the patch over in bug 932198 since it passed Try (with a bit of fuzzing of a couple of font tests) and goes a little further than the patch here in its conversion to Moz2D.
Depends on: 932198
Comment 12•10 years ago
|
||
Is bug 932198 going to be enough to fix all cases where a cairo gfxContext gets passed to imgFrame::Draw?
Comment 13•10 years ago
|
||
Bug 932198 fixes this specific case. Hopefully there are no other cases where imgFrame::Draw attempts to draw to a thebes gfxContext.
Assignee: mwu → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•10 years ago
|
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•