Closed Bug 1025675 Opened 10 years ago Closed 10 years ago

[Autocorrect] The autocorrect feature does not work properly when the caret position is changed

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1015541

People

(Reporter: julienw, Unassigned)

Details

(Keywords: regression)

STR:
1. have autocorrect and suggestion enabled
2. launch SMS
3. press "new message" button
4. ensure you use the english layout
5. write: "how are you worl"
=> "work" should be the current suggestion
6. put the caret in the middle of "are" (for example after the "a")
=> Notice that "work" is still the current suggestion
7. press the "space" key
=> Notice that "work " has been added, replacing the 4 characters "ow a".
=> Current message is "Hwork re you worl"
8. press "backspace" key
=> "work " has been replaced by "worl ". Current message is "Hworl re you worl"

What should have happened instead:
* after step 6, the suggestion should be recomputed according to the current caret position. Ideally it should take into account only the previous characters, leaving the next characters alone (even if there is no space) so that we can easily make a new word out of it.

instead of step 7, if you write more characters (eg: "d"), as far as the suggestion goes, everything happens as if we didn't move the caret.


Peak v1.4: images-peak-v1.4-2014-06-15.Gecko-0ae1921.Gaia-164644d.zip

I'm quite sure this didn't happen in v1.3, so I put the "regression" keyword and ask a 1.4 blocker. I assure you this makes the autocorrect really difficult to use in a daytoday use.

Note that I see this issue in v1.4 for a long time, but I didn't report because my build was quite old until recently (because geeksphone didn't update them for some time).
Here is another related STR:

1-4. do the previous STR
5. write "worl"
6. press "send"
=> notice the 'work' is still the suggested word
7. press "space"
=> "work" is inserted
QA Wanted to check 1.3.
Keywords: qawanted
QA Contact: lmauritson
Please send us a screen shot on the Flame.
Flags: needinfo?(felash)
(In reply to Jason Smith [:jsmith] from comment #2)
> QA Wanted to check 1.3.

Being thorough here as instructed:

>Reproduces on:

Device: Flame 2.1 - Master - Repro
BuildID: 20140617040203
Gaia: eac13407742a55b11e1877b4df2abdfd22cd582e
Gecko: bb35d1b73634
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2

Device: Flame 2.0 - Repro
Build ID: 20140617000201
Gaia: 0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko: 7f309a3a4d3d
Version: 32.0a2 (2.0) 
Firmware Version: v121-2

Device: Flame 1.4 - Repro
BuildID: 20140617000202
Gaia: 4b3428e85b428e577a0f96cba6121c4ca1c91f8a
Gecko: ba55b5a7b20d
Version: 30.0 (1.4) 
Firmware Version: v121-2

Device: Buri 2.1 - Master - Repro
BuildID: 20140617040203
Gaia: eac13407742a55b11e1877b4df2abdfd22cd582e
Gecko: bb35d1b73634
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v1.2device.cfg

Device: Buri 2.0 - Repro
BuildID: 20140617000201
Gaia: 0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko: 7f309a3a4d3d
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg

Device: Buri 1.4 - Repro
BuildID: 20140617000202
Gaia: 4b3428e85b428e577a0f96cba6121c4ca1c91f8a
Gecko: ba55b5a7b20d
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg

Device: Open_C 1.4 - Repro
BuildID: 20140617000202
Gaia: 4b3428e85b428e577a0f96cba6121c4ca1c91f8a
Gecko: ba55b5a7b20d
Version: 30.0 (1.4) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Device: Open_C 2.0 - Repro
BuildID: 20140617000201
Gaia: 0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko: 7f309a3a4d3d
Version: 32.0a2 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Device: Open_C 2.1 - Master - Repro
BuildID: 20140617040203
Gaia: eac13407742a55b11e1877b4df2abdfd22cd582e
Gecko: bb35d1b73634
Version: 33.0a1 (2.1 - Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

>Does NOT reproduce on

Device: Buri 1.3 - No Repro
Build ID: 20140617024001
Gaia: 7f361e67aa65e40adb2233ab247ebd0f142cfbf1
Gecko: 4afb49342d25
Version: 28.0 (1.3) 
Firmware Version: v1.2device.cfg

Device: Open_C 1.3 (Base) - No Repro
Build ID: 20140505052400
Version: 28.0 (1.3) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Device: Flame 1.3 (Base) - No Repro
Build ID: 20140610200025
Gaia: e106a3f4a14eb8d4e10348efac7ae6dea2c24657
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v121-2
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
Flags: needinfo?(jmitchell)
Before doing a window, let's get a video of the bug.
I don't have a Flame yet, but I'm sure QA will do the video properly.

Let's move forward, I think it's as clear for you than for me that it's a regression now.
Flags: needinfo?(felash)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Keywords: qawanted
blocking-b2g: 1.4? → ---
You need to log in before you can comment on or make changes to this bug.