Closed
Bug 1025723
Opened 10 years ago
Closed 10 years ago
[LockScreen][System] Change the old locking events with new window events
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gweng, Assigned: gweng)
References
Details
Attachments
(1 file)
The old 'unlock', 'will-unlock' and 'lock' events, should be replaced with 'lockscreenwindow-closed', 'lockscreenwindow-closing' and 'lockscreenwindow-opened'.
|
Assignee | |
Comment 1•10 years ago
|
||
I've changed the old events with new ones, and the patch passed TBPL except connection timeouts that also occur at the other PRs:
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=1db5daea328add7bf54944626c1d1f2f69638933
It also passed all Travis tests:
https://travis-ci.org/mozilla-b2g/gaia/builds/27658223
Attachment #8441802 -
Flags: review?(alive)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8441802 [details]
Patch
Thanks
Attachment #8441802 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gweng
|
|
Assignee | |
Updated•10 years ago
|
Blocks: lockscreen-as-app
|
||
Comment 4•10 years ago
|
||
Other places that depend on the lock/unclock notifications:
1 - USB Mass Storage - seems to have been fixed
2 - AdbController - http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#429
Does the new app generate lockscreen.locked and lockscreen.unlocked events?
This probably also affects bug 1026555
|
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•