Closed Bug 1026003 Opened 10 years ago Closed 10 years ago

UI telemetry for opening pages in new tabs from web content contextmenu

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox31 fixed, firefox32 fixed, firefox33 fixed)

RESOLVED FIXED
Firefox 33
Tracking Status
firefox31 --- fixed
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: rnewman, Assigned: mfinkle)

References

Details

Attachments

(1 file)

09:43:17 <@mfinkle> we still don't cover loading urls via "open in new/private tab" from web context menu Let's get it done!
Summary: UI telemetry for opening pages in new tabs → UI telemetry for opening pages in new tabs from web content menu
Summary: UI telemetry for opening pages in new tabs from web content menu → UI telemetry for opening pages in new tabs from web content contextmenu
Uses the same scheme we use in other loadurl telemetry
Assignee: nobody → mark.finkle
Attachment #8440812 - Flags: review?(liuche)
Comment on attachment 8440812 [details] [diff] [review] uitelemetry-loadurl-webcontext v0.1 Review of attachment 8440812 [details] [diff] [review]: ----------------------------------------------------------------- One comment, o/w lgtm! ::: mobile/android/chrome/content/browser.js @@ +502,5 @@ > > NativeWindow.contextmenus.add(Strings.browser.GetStringFromName("contextmenu.openInPrivateTab"), > NativeWindow.contextmenus.linkOpenableContext, > function(aTarget) { > + UITelemetry.addEvent("loadurl.1", "contextmenu", null); I'd like to see us differentiate between private and non-private tabs, so maybe an extra here (or for consistency/if you're feeling pedantic, extras in both events).
Attachment #8440812 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #2) > Comment on attachment 8440812 [details] [diff] [review] > uitelemetry-loadurl-webcontext v0.1 > > Review of attachment 8440812 [details] [diff] [review]: > ----------------------------------------------------------------- > > One comment, o/w lgtm! > > ::: mobile/android/chrome/content/browser.js > @@ +502,5 @@ > > > > NativeWindow.contextmenus.add(Strings.browser.GetStringFromName("contextmenu.openInPrivateTab"), > > NativeWindow.contextmenus.linkOpenableContext, > > function(aTarget) { > > + UITelemetry.addEvent("loadurl.1", "contextmenu", null); > > I'd like to see us differentiate between private and non-private tabs, so > maybe an extra here (or for consistency/if you're feeling pedantic, extras > in both events). We have the same situation with the home pane context menu. It has "open new" and "open private" actiosn on it. we skipped adding extras to it for tracking normal and private. We current use "action" for track private tabs, but we could revisit adding extras to the right places for "loadurl". I'll file a different bug for that, since it affects more than this patch.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Comment on attachment 8440812 [details] [diff] [review] uitelemetry-loadurl-webcontext v0.1 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Allows collecting more telemetry data Testing completed (on m-c, etc.): Working on m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #8440812 - Flags: approval-mozilla-beta?
Attachment #8440812 - Flags: approval-mozilla-aurora?
Attachment #8440812 - Flags: approval-mozilla-beta?
Attachment #8440812 - Flags: approval-mozilla-beta+
Attachment #8440812 - Flags: approval-mozilla-aurora?
Attachment #8440812 - Flags: approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: