Closed Bug 1026075 Opened 10 years ago Closed 10 years ago

App Delete confirm screen does not use building blocks

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
feature-b2g 2.0
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: epang, Assigned: crdlc)

References

Details

(Whiteboard: visual design [systemsfe])

Attachments

(3 files)

confirm screen.png
(deleted), image/png
Details
Github pull request
(deleted), text/html
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details
IMAG0561.jpg
(deleted), image/jpeg
Details
Attached image confirm screen.png (deleted) —
The confirmation screen for deleting an app is not using the building blocks. (When deleting a bookmark the building blocks are used). The string under the division line is smaller then expected. See attached image. Screen on the right is using the building blocks while the left is not.
Blocks: vertical-home-next
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Component: Gaia::Search → Gaia::Homescreen
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request (deleted) —
Attachment #8441242 - Flags: review?(kgrandon)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.0
Whiteboard: visual design → visual design [systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
Target Milestone: 2.0 S5 (4july) → 2.0 S4 (20june)
Comment on attachment 8441242 [details] Github pull request This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.
Attachment #8441242 - Flags: approval-gaia-v2.0?(bbajaj)
Mockitest deletion panel is now using building blocks on master.
Status: RESOLVED → VERIFIED
Comment on attachment 8441242 [details] Github pull request THanks for the pro active verification Johan!
Attachment #8441242 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Attached image IMAG0561.jpg (deleted) —
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141127000203 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b Build-ID 20141127001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: