Closed Bug 1026467 Opened 10 years ago Closed 10 years ago

[Vertical] Homescreen is out of sync with CollectionsDatabase

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: amirn, Assigned: ranbena)

References

Details

I don't have an STR but I have witnessed cases where: 1. the collections_database reports 5 collections installed but only 2 are available on the homescreen 2. the collection's homescreen icon reverts to the default icon (white rocket) The error is logged when removing a collection: E/GeckoConsole( 289): [JavaScript Error: "IndexedDB UnknownErr: IDBTransaction.cpp:867"]
Assignee: nobody → ran
Amir, is it safe to say that this happens after deleting Collections from homescreen?
I think so, yes. after deleting a collection, the CollectionDatabase still reports it is installed. Kevin, are we missing a sync. method? in https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/js/sources/collection.js#L29-L30
Flags: needinfo?(kgrandon)
Without STR, we probably can't block on this.
No longer blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
The sync method shouldn't be needed until we have replaceable homescreens and other apps leverage CollectionsDatabase, but we could use it to safeguard against this. If I get time I will look at this.
Flags: needinfo?(kgrandon)
STR are detailed in Bug 1025441. This issue induces that a deleted bookmark is back again after a phone reboot.
Blocks: 1025441
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking+][VH-FC-blocking+]
I don't understand comment 5. bug 1025441 is already fixed & this is talking about collections. How is this related to bookmarks?
Flags: needinfo?(jlorenzo)
Bug 1025441 is not entirely fixed as per comment https://bugzilla.mozilla.org/show_bug.cgi?id=1025441#c10 and next. This seems to be the root cause of the living dead bookmarks.
Flags: needinfo?(jlorenzo)
Sorry, I was more referring to just an engineering code cleanup thing. There should be nothing wrong with bookmarks now, so let's not worry about those here.
No longer blocks: 1025441
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+] → [VH-FL-blocking-][VH-FC-blocking-]
blocking-b2g: 2.0? → ---
I'm not sure when it landed, but it sounds like this was due to the ID generation being the same? I haven't seen this create problems recently, so going to close it, but please reopen if you still see it. Also possibly related to bug 1028322.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.