Closed
Bug 1026986
Opened 10 years ago
Closed 10 years ago
Cannot build Qt-build due to nsEmbedFunctions.cpp:796:26: error: ‘InstallX11ErrorHandler’ was not declared in this scope
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
I cannot build Qt-build with following error:
> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp: In function ‘void XRE_InstallX11ErrorHandler()’:
> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp:796:26: error: ‘InstallX11ErrorHandler’ was not declared in this scope
> 14:05.19 InstallX11ErrorHandler();
> 14:05.19 ^
This must be regressed by bug 968196 it added |#if (MOZ_WIDGET_GTK == 2)| to the necessary method for Qt-build.
|
Assignee | |
Comment 1•10 years ago
|
||
Quick fix.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8442718 [details] [diff] [review]
Patch
Yeah, that's because we added the GTK2 check here. But I'm not a module owner here, it's Karl.
Attachment #8442718 -
Flags: review?(stransky) → review?(karlt)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8442718 [details] [diff] [review]
Patch
I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site XRE_InstallX11ErrorHandler()
Attachment #8442718 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to Karl Tomlinson (needinfo?:karlt) from comment #3)
> Comment on attachment 8442718 [details] [diff] [review]
> Patch
>
> I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site
> XRE_InstallX11ErrorHandler()
Agreed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/55620c684232
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•