Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 10 years ago

I cannot build Qt-build with following error:

> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp: In function ‘void XRE_InstallX11ErrorHandler()’:
> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp:796:26: error: ‘InstallX11ErrorHandler’ was not declared in this scope
> 14:05.19    InstallX11ErrorHandler();
> 14:05.19                           ^

This must be regressed by bug 968196 it added |#if (MOZ_WIDGET_GTK == 2)| to the necessary method for Qt-build.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 10 years ago

Quick fix.

	Martin Stránský [:stransky] (ni? me)
	Comment 2 • 10 years ago

Comment on attachment 8442718 [details] [diff] [review]
Patch

Yeah, that's because we added the GTK2 check here. But I'm not a module owner here, it's Karl.

	Karl Tomlinson (:karlt)
	Comment 3 • 10 years ago

Comment on attachment 8442718 [details] [diff] [review]
Patch

I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site XRE_InstallX11ErrorHandler()

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 10 years ago

(In reply to Karl Tomlinson (needinfo?:karlt) from comment #3)
> Comment on attachment 8442718 [details] [diff] [review]
> Patch
> 
> I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site
> XRE_InstallX11ErrorHandler()

Agreed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/55620c684232

	Ed Morley [:emorley]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/55620c684232