Ed Morley [:emorley] Assignee
	Description • 10 years ago

In some of the log output the newline is missing, others not. I'm guessing by luck/platform we're adding a newline - but imagine we should be doing so ourselves when using fprintf_stderr()

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41949590&tree=Try#error0
03:31:48     INFO -  Automation Error: Non-local network connections are disabled and a connection attempt to safebrowsing.google.com (74.125.239.98) was made.  You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests).  Browser services should be disabled or redirected to a local server.1403087268647	Marionette	INFO	loaded marionette-listener.js

	Nathan Froyd [:froydnj]
	Comment 2 • 10 years ago

Comment on attachment 8442023 [details] [diff] [review]
Add newline to MOZ_DISABLE_NONLOCAL_CONNECTIONS fprintf_stderr()

Review of attachment 8442023 [details] [diff] [review]:
-----------------------------------------------------------------

Doh!

	Ed Morley [:emorley] Assignee
	Comment 3 • 10 years ago

Thanks :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6894b106f39e

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/6894b106f39e