Closed Bug 1027034 Opened 10 years ago Closed 10 years ago

Failure to build with Gtk3 < 3.5.12.

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Properly set up Gtk+3 compatibility headers
(deleted), patch
karlt
: review+
Details | Diff | Splinter Review 
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:582:17: error: 'GtkInputPurpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:582:33: error: expected ';' before 'purpose'
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:603:21: error: 'purpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:603:31: error: 'GTK_INPUT_PURPOSE_PASSWORD' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:605:21: error: 'purpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:605:31: error: 'GTK_INPUT_PURPOSE_EMAIL' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:607:21: error: 'purpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:607:31: error: 'GTK_INPUT_PURPOSE_URL' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:609:21: error: 'purpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:609:31: error: 'GTK_INPUT_PURPOSE_PHONE' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:611:21: error: 'purpose' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:611:31: error: 'GTK_INPUT_PURPOSE_NUMBER' was not declared in this scope
/builds/slave/try-l64-0000000000000000000000/build/widget/gtk/nsGtkIMModule.cpp:614:56: error: 'purpose' was not declared in this scope
make[5]: *** [nsGtkIMModule.o] Error 1

The problem is that the compat wrapper that was added in bug 931378 is actually not used.

        Attachment #8442059 -
        Flags: review?(karlt)

    
  
Blocks: try-gtk3

        Attachment #8442059 -
        Flags: review?(karlt) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/48639e44baf4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

    
  
Blocks: 1034064

    
  
No longer blocks: 1034064

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: