Closed
Bug 1027063
Opened 10 years ago
Closed 10 years ago
Add redirect from '/' to '/index.html' for Ouija
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: smshdwll, Mentored)
References
Details
(Whiteboard: [good first bug][lang=python])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
dminor
:
review+
|
Details | Diff | Splinter Review |
Ouija (https://wiki.mozilla.org/Auto-tools/Projects/Ouija) is a tool for test failure rate analysis.
When we moved to Flask, we lost '/' as an alias for '/index.html' which means if you go to the Ouija instance at http://54.215.155.53, you get a 404 error. This should be fixed so that we are redirected to (or at least shown) /index.html.
Assignee | ||
Comment 1•10 years ago
|
||
This is my first bug, so if I've done something wrong, please let me know! I really want to start giving back to Mozilla.
Reporter | ||
Comment 2•10 years ago
|
||
Hi Sam,
Thanks for looking at this, your fix works great! The only problem is the format of your attachment. Rather than the whole file, you should attach a diff. The process is like this:
git checkout -b bug-1027063-fix #makes a branch for your changes
# make fix
git add server.py
git commit -m "Bug 1027063 - Add redirect from '/' to '/index.html' for Ouija"
git format-patch -1
This will give you a file called 0001-Bug-1027063-... which you can attach to this bug. If you haven't set up git on your system before, it will ask you to set your name and email when you commit, which will then be part of the patch.
Since this project on github, you can also use a github pull request:
1) Fork the project on github
2) Clone the fork to your local system
3) Do the following:
git checkout -b bug-1027063-fix
# make fix
git add server.py
git commit -m "Bug 1027063 - Add redirect from '/' to '/index.html' for Ouija"
git push origin bug-1027063-fix
4) In github, visit your fork and you should see a button that will let you create a pull request.
Part of fixing a good first bug is learning how to format your patch for review, so please give one of the above options a try. Let me know if you get stuck. Thanks!
Assignee: nobody → smshdwll
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Alright, I followed your instructions! Now that I have this branch of the repo, how do I merge back into main? Will this update to the new version when the source is updated? Sorry, I'm not used to using git with multiple contributors.
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8442748 [details] [diff] [review]
Followed the correct method for creating a patch.
Review of attachment 8442748 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks. I'll merge the patch for you.
Attachment #8442748 -
Flags: review+
Reporter | ||
Comment 5•10 years ago
|
||
Thanks for contributing!
There are some more Ouija bugs listed at https://wiki.mozilla.org/Auto-tools/Projects/Ouija if you're interested in doing more here, or you can check out one of our other projects.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•