Closed
Bug 1027084
Opened 10 years ago
Closed 10 years ago
browser_819510_perwindowpb.js crashes when run locally due to about:home snippets accessing the network
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
smacleod
:
review+
|
Details | Diff | Splinter Review |
I don't know why this doesn't happen on our CI but it does happen for me locally.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8442105 -
Flags: review?(mak77)
Assignee | ||
Comment 2•10 years ago
|
||
It might also make sense to move that pref to a global place where it's set for all prefs. Otherwise other tests will probably just start failing whenever new tests are added.
Comment 3•10 years ago
|
||
Comment on attachment 8442105 [details] [diff] [review]
0001-Bug-1027084-Disable-about-home-snippets-when-running.patch
Review of attachment 8442105 [details] [diff] [review]:
-----------------------------------------------------------------
How is this test loading about:home? I thought we had removed it from most of the tests
Assignee | ||
Comment 4•10 years ago
|
||
I have no clue. Something must be loading snippets, I don't know what exactly.
Assignee | ||
Comment 5•10 years ago
|
||
Yeah, about:home is actually getting loaded but I don't know why :) Doesn't happen when I run only this single test but happens always when I run the whole test suite.
Assignee | ||
Comment 6•10 years ago
|
||
about:home is the default page that is loaded when opening new windows. We should change sessionstore tests to explicitly open new windows with about:blank as the start page.
Attachment #8442105 -
Attachment is obsolete: true
Attachment #8442105 -
Flags: review?(mak77)
Attachment #8445833 -
Flags: review?(smacleod)
Updated•10 years ago
|
Attachment #8445833 -
Flags: review?(smacleod) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
sorry had to backout for bc1 - testbustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42612119&tree=Fx-Team
Assignee | ||
Comment 9•10 years ago
|
||
I totally missed that the failing test behaves differently on OSX and runs a different set of tests, how evil.
Assignee | ||
Comment 10•10 years ago
|
||
Pushed again with a small fix for non-OSX platforms:
https://hg.mozilla.org/integration/fx-team/rev/6b8f91ea1013
Assignee | ||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in
before you can comment on or make changes to this bug.
Description
•