Closed
Bug 10273
Opened 26 years ago
Closed 25 years ago
NECKO: about:blank as linked stylesheet causes crash
Categories
(Core :: Networking, defect, P3)
Tracking
()
VERIFIED
FIXED
M10
People
(Reporter: dbaron, Assigned: warrensomebody)
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
If about:blank is the href for a linked stylesheet, viewer crashes.
Tested on: 1999-07-20-10-M9, Linux.
Test case to be attached.
Reporter | ||
Comment 1•26 years ago
|
||
Reporter | ||
Updated•26 years ago
|
Severity: normal → critical
Updated•26 years ago
|
Status: NEW → ASSIGNED
Comment 2•26 years ago
|
||
Amusingly enough, this takes Nav down too (hard), so don't even try it. (I had
to reboot my machine to get networking going again after loading the test in
4.6)
Updated•26 years ago
|
Assignee: peterl → gagan
Status: ASSIGNED → NEW
Component: Style System → Networking-Core
Comment 3•26 years ago
|
||
The problem is that for "about:blank" NS_NewUnicharStreamLoader calls the
callback function synchronously. As far as I know, that should never happen. Is
this due to the "about:blank" workaround that went in for ender? Will necko have
the same behavior? If so, send this bug back to me and I'll make the CSSLoader
deal with it.
Updated•26 years ago
|
QA Contact: chrisd → paulmac
Reporter | ||
Comment 4•26 years ago
|
||
I'm seeing what's probably the same thing happening in
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=753 with a nonexistent
resource: URL (the old xul.css). The stack trace is very similar.
Summary: about:blank as linked stylesheet causes crash → NECKO: about:blank as linked stylesheet causes crash
Reporter | ||
Comment 6•26 years ago
|
||
I'm seeing similar crashes for nonexistant file: stylesheets.
Comment 7•26 years ago
|
||
dbaron, have you tried this with a necko build?
Reporter | ||
Comment 8•26 years ago
|
||
Not yet. I should be able to in a few days.
Reporter | ||
Comment 9•26 years ago
|
||
Actually, I believe this may have been Linux-only, so I can't test it for a
while.
Assignee | ||
Updated•26 years ago
|
Assignee: gagan → warren
Assignee | ||
Comment 10•26 years ago
|
||
I'll look at this.
Comment 11•26 years ago
|
||
this is crashing on all platforms
Assignee | ||
Comment 12•26 years ago
|
||
This is still a problem -- it hits an assert in nsCSSLoader.cpp. How important
is this to change? Making necko work differently for this case could be done
(basically this is a case where calling AsyncRead does the work before
returning), but it seems somewhat unnecessary from necko's perspective. Maybe
nsCSSLoader should change.
Comment 13•26 years ago
|
||
I accept the fact that Necko doesn't *need* to use async callbacks for this
case, but it is extremely bad if Necko uses mixed models. The call site code can
be/is very different for synchronous reads vs async reads, especially when the
behavior varies by URL scheme and *platform*.
Please make the network code just always be async. It is a simpler model and
will avoid many similar problems in the future.
Comment 14•26 years ago
|
||
Although it doesn't crash my M10 build on Windows (build ID 1999082008), it does
cause garbage to be drawn in the main browser window. Changing OS to ALL. (Mac
OS build is currently not working.)
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 15•26 years ago
|
||
Can we move this to m10 then?
Comment 16•25 years ago
|
||
If this is not to be fixed in M9, then we'll need it Release Noted. so, ya
wanna move to M10?
Comment 17•25 years ago
|
||
I don't believe QA have a problem with fixing this in the M10 timeframe.
Comment 18•25 years ago
|
||
Results using the 1999082016 build (latest M9) build:
Windows NT: Apprunner crashes; Talkback report generated.
Linux: Apprunner crashes.
Mac OS: Apprunner crashes.
Assignee | ||
Updated•25 years ago
|
Target Milestone: M9 → M10
Assignee | ||
Comment 19•25 years ago
|
||
Ok, let's move it to m10.
Comment 20•25 years ago
|
||
I already added to release notes.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 21•25 years ago
|
||
I just checked in fixes for this.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 22•25 years ago
|
||
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=952 no longer crashes,
marking verified.
Comment 23•25 years ago
|
||
Bulk move of all Necko (to be deleted component) bugs to new Networking
component.
You need to log in
before you can comment on or make changes to this bug.
Description
•