Closed
Bug 1027440
Opened 10 years ago
Closed 10 years ago
Test plugins are not built in gtk3 builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
As a consequence, several tests are broken.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8442621 -
Flags: review?(mshal)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8442621 [details] [diff] [review]
Build test plugins when building with --enable-default-toolkit=cairo-gtk3
>+elif toolkit in ('gtk2', 'gtk3'):
> UNIFIED_SOURCES += [
> relative_path + '/nptest_gtk2.cpp',
I guess we don't need a specific nptest_gtk3.cpp?
Attachment #8442621 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Michael Shal [:mshal] (no reviews until 6/30) from comment #2)
> I guess we don't need a specific nptest_gtk3.cpp?
No, and in fact, the gtk3 build builds gtk2 plugins.
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•