Closed
Bug 1027570
Opened 10 years ago
Closed 10 years ago
Update lockscreen atom as per bug 970824
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: zcampbell, Assigned: zcampbell)
References
Details
Attachments
(1 file)
The way we lock screen has changed, thus the atom should be updated.
Info/examples are in bug 970824.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → zcampbell
Assignee | ||
Comment 1•10 years ago
|
||
Hey Snowman, can you f? this for me? I hope I have understood bug 970824 correctly.
Are we still locking the screen in the ideal manner?
Thanks!
Attachment #8444464 -
Flags: feedback?(gweng)
Comment 2•10 years ago
|
||
Comment on attachment 8444464 [details]
Github PR
There seems a missed
> let lockscreen = window.wrappedJSObject.lockScreen;
which is no needed anymore.
Attachment #8444464 -
Flags: feedback?(gweng)
Comment 3•10 years ago
|
||
I've commented on GitHub, too. If it passed all tests, I think we can make it r+ and land it. Thanks for your patching, which I missed in the original bug!
Comment 4•10 years ago
|
||
Comment on attachment 8444464 [details]
Github PR
Zac has explained that we still use the object. So the patch is okay then.
Attachment #8444464 -
Flags: feedback+
Assignee | ||
Comment 5•10 years ago
|
||
Merged
https://github.com/mozilla-b2g/gaia/commit/44109a1f35ee74f97f00989aaa623e2565f51adf
and immediately backed out as I did no tnotice bug 970824 had been backed out:
https://github.com/mozilla-b2g/gaia/commit/77b09fdc169c34f285ed92090f090a2d3e9bf688
!
Comment 6•10 years ago
|
||
Sorry I was offline today and have no change to notice you on this bug. The bug cause a regression Bug 1028374 that seems easily to be fixed, however, unfortunately I don't have time to solve it after Jason NI me, so Tim backed it out.
Assignee | ||
Comment 7•10 years ago
|
||
Snowman already did this when he re-landed bug 970824 (thanks Greg).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•