Closed Bug 1027570 Opened 10 years ago Closed 10 years ago

Update lockscreen atom as per bug 970824

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: zcampbell, Assigned: zcampbell)

References

Details

Attachments

(1 file)

Github PR
(deleted), text/x-github-pull-request
gweng
: feedback+
Details
The way we lock screen has changed, thus the atom should be updated. Info/examples are in bug 970824.
Assignee: nobody → zcampbell
Attached file Github PR (deleted) —
Hey Snowman, can you f? this for me? I hope I have understood bug 970824 correctly. Are we still locking the screen in the ideal manner? Thanks!
Attachment #8444464 - Flags: feedback?(gweng)
Comment on attachment 8444464 [details] Github PR There seems a missed > let lockscreen = window.wrappedJSObject.lockScreen; which is no needed anymore.
Attachment #8444464 - Flags: feedback?(gweng)
I've commented on GitHub, too. If it passed all tests, I think we can make it r+ and land it. Thanks for your patching, which I missed in the original bug!
Comment on attachment 8444464 [details] Github PR Zac has explained that we still use the object. So the patch is okay then.
Attachment #8444464 - Flags: feedback+
Depends on: 994176
Sorry I was offline today and have no change to notice you on this bug. The bug cause a regression Bug 1028374 that seems easily to be fixed, however, unfortunately I don't have time to solve it after Jason NI me, so Tim backed it out.
Snowman already did this when he re-landed bug 970824 (thanks Greg).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: