Closed
Bug 1027725
Opened 10 years ago
Closed 10 years ago
Make calendar app async operations use promises
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: gaye, Assigned: gaye)
References
Details
(Whiteboard: [priority][p=5])
Attachments
(1 file)
See proposal here https://github.com/gaye/calendar-refactor/blob/master/proposals/promises.md.
Assignee | ||
Updated•10 years ago
|
Summary: Make async operations use promises → Make calendar app async operations use promises
Assignee | ||
Updated•10 years ago
|
Whiteboard: [priority]
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.0 S5 (4july)
Assignee | ||
Comment 1•10 years ago
|
||
I was thinking that we could go ahead and wrap the existing node-style callback stuff with this so that we can have a gradualish migration from the existing node-style callback backend apis to promises. Thoughts guys?
Assignee: nobody → gaye
Attachment #8455540 -
Flags: feedback?(mmedeiros)
Attachment #8455540 -
Flags: feedback?(jlal)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8455540 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716
Positive feedback from :lightsofapollo and :millermedeiros on irc so bumping to preliminary review. Preliminary since I am meaning to add a couple tests for the new access modes on provider/store stuff.
Attachment #8455540 -
Flags: review?(mmedeiros)
Attachment #8455540 -
Flags: feedback?(mmedeiros)
Attachment #8455540 -
Flags: feedback?(jlal)
Comment 3•10 years ago
|
||
Comment on attachment 8455540 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21716
I liked the tests and also the flexibility - supporting both styles will allow us to migrate the code gradually. And +1 for the helper method to denodeify all methods at once. Just a small nit about IIFE (unsure if it's needed).
Attachment #8455540 -
Flags: review?(mmedeiros) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Landed on master. Thanks for working with me on this Miller! https://github.com/mozilla-b2g/gaia/commit/5edca8cd06409b8bf404de4adf7ea08fc2940fd7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: [priority] → [priority][p=5]
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•