Closed
Bug 1027979
Opened 10 years ago
Closed 10 years ago
Remove more dead code from keyboard app
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S6 (18july)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: timdream, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(2 files)
isContinousSpacePressed and showPendingSymbols are not used anymore.
|
Reporter | |
Comment 1•10 years ago
|
||
I am going to remove isContinousSpacePressed in bug 1029356. This bug to be keep for removing |showPendingSymbols| in render.js.
|
|
Reporter | |
Comment 2•10 years ago
|
||
Actually... Rudy, can you verify this WIP and submit a pull request?
I think it's faster this way.
Flags: needinfo?(rlu)
|
Assignee | |
Updated•10 years ago
|
Assignee: timdream → rlu
|
|
Assignee | |
Comment 4•10 years ago
|
||
Will set review after the CI all pass.
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S6 (18july)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8451234 [details]
Patch V1
I think this is ready to review because the Gaia UI Test failure is irrelevant.
Tim, could you please help on this?
Thank you.
Attachment #8451234 -
Flags: review?(timdream)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8451234 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/d101974c43366020a91b86d1fd42713fe88d9e48
Thanks for the review.
You need to log in
before you can comment on or make changes to this bug.
Description
•