Closed
Bug 1028018
Opened 10 years ago
Closed 10 years ago
[Settings] privacy_sprite.png should be removed
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: reznord, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
/settings/style/images/privacy_sprite.png /settings/style/images/privacy_sprite@1.5x.png /settings/style/images/privacy_sprite@2.25x.png /settings/style/images/privacy_sprite@2x.png These images should be removed as now we use /shared/resources/branding/privacy_sprite.png instead.
Assignee | ||
Comment 1•10 years ago
|
||
Hi, I am interested in working on this bug. Can I be assigned to this bug? Thanks in advance, Regards, Anup
Reporter | ||
Comment 2•10 years ago
|
||
Hi Anup, Thank you for the help! Let me know if you encounter any problem. Best, Arthur
Assignee: nobody → allamsetty.anup
Updated•10 years ago
|
Mentor: arthur.chen
Whiteboard: [good first bug][mentor=arthurcc] → [good first bug]
Assignee | ||
Comment 3•10 years ago
|
||
Created a PR link with the changes requested in the bug
Attachment #8446371 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 4•10 years ago
|
||
Got the Travis CI build failed after applying the changes to the code. It worked fine with the try-server-hook. Arthur can you please have a look at the pull request and tell me what the problem is?
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8446371 [details]
PR link
Looks good to me. As for the travis problem, there are existing intermittent failures and should not related to your patch. The patch is good to land with TBPL passed. Thank you for helping!
Attachment #8446371 -
Flags: review?(arthur.chen) → review+
Reporter | ||
Comment 6•10 years ago
|
||
TBPL passed: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=027a753d3d657caf8fdf0f5ba2a3e131d9a76093 master: e86945765ca83795841ea1b79e6cde9dd0cc448d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•