Closed
Bug 1028079
Opened 10 years ago
Closed 10 years ago
App Manager v2: fix consistency in strings ("addon", capitalization)
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: flod, Assigned: paul)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
I peeked at the current strings for App Manager v2 and there are some issues.
http://hg.mozilla.org/mozilla-central/file/bdac18bd6c74/browser/devtools/webide/locales/en-US
"addon" needs to be spelled consistently as "add-on"
<!ENTITY addons_aboutaddons "Open Addons Manager">
error_cantFetchAddonsJSON=Can't fetch the addon list: %S
addons_adb_label=ADB Addon Helper
Also, capitalization doesn't look consistent in some menu items
<!ENTITY projectMenu_selectApp_label "Open App…">
vs
<!ENTITY projectMenu_play_label "Install and run">
(In reply to Francesco Lodolo [:flod] from comment #0)
> addons_adb_label=ADB Addon Helper
For this case, I think it's clearer to say only "ADB Helper", so we should just change to that.
Also, for capitalization, this one should be updated too:
<!ENTITY viewMenu_showAddons_label "Manage simulators">
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8465331 -
Flags: review?(jryans)
Attachment #8465331 -
Flags: feedback?(francesco.lodolo)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8465331 [details] [diff] [review]
v1
Review of attachment 8465331 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/webide/locales/en-US/webide.dtd
@@ +13,5 @@
> <!ENTITY projectMenu_importHostedApp_label "Open Hosted App…">
> <!ENTITY projectMenu_importHostedApp_accesskey "H">
> <!ENTITY projectMenu_selectApp_label "Open App…">
> <!ENTITY projectMenu_selectApp_accessley "S">
> +<!ENTITY projectMenu_play_label "Install And Run">
I think that this should be "Install and Run" (title case, so conjunctions use lowercase).
Attachment #8465331 -
Flags: feedback?(francesco.lodolo) → feedback+
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8465342 -
Flags: review?(jryans)
Assignee | ||
Updated•10 years ago
|
Attachment #8465331 -
Attachment is obsolete: true
Attachment #8465331 -
Flags: review?(jryans)
Comment on attachment 8465342 [details] [diff] [review]
v1.1
Review of attachment 8465342 [details] [diff] [review]:
-----------------------------------------------------------------
I tried to audit all the strings I could find by looking at where there are used in the UI, so I found a few more that would be good to fix:
<!ENTITY newAppHeader "Select template"> Use title case here.
<!ENTITY newAppProjectName "Project Name:"> Nit: Colon not needed here.
r+ with these other tweaks added.
::: browser/devtools/webide/locales/en-US/webide.dtd
@@ +87,5 @@
>
>
> <!-- Decks -->
>
> <!ENTITY deck_close "close">
This should be "Close" to match the other title-case links it (sometimes) appears next to.
@@ +90,5 @@
>
> <!ENTITY deck_close "close">
>
> <!-- Addons -->
> <!ENTITY addons_title "Extra Components:">
Nit: I think the colon isn't needed. Not typically used on section headers like this (ex. see toolbox options panel).
@@ +97,5 @@
> <!-- Prefs -->
> <!ENTITY prefs_title "Preferences">
> <!ENTITY prefs_editor_title "Editor">
> <!ENTITY prefs_general_title "General">
> <!ENTITY prefs_restore "Restore defaults">
This is a link in the top-right, so use title-case.
@@ +98,5 @@
> <!ENTITY prefs_title "Preferences">
> <!ENTITY prefs_editor_title "Editor">
> <!ENTITY prefs_general_title "General">
> <!ENTITY prefs_restore "Restore defaults">
> <!ENTITY prefs_simulators "Manage simulators">
Same, title-case.
::: browser/devtools/webide/locales/en-US/webide.properties
@@ +32,5 @@
> addons_unstable=unstable
> addons_simulator_label=Firefox OS %1$S Simulator (%2$S)
> addons_install_button=install
> addons_uninstall_button=uninstall
> +addons_adb_label=ADB Add-on Helper
This sounds better as "ADB Helper Add-on", since the name of the add-on is "ADB Helper".
Attachment #8465342 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8465342 -
Attachment is obsolete: true
Attachment #8465567 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•