Closed
Bug 1028142
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of CSF::VideoControl
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bjacob, Assigned: anujagarwal464)
References
Details
Attachments
(2 files)
(deleted),
patch
|
bjacob
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.
One of them is: CSF::VideoControl
Flags: needinfo?(rjesup)
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → anujagarwal464
Attachment #8454912 -
Flags: feedback?(bjacob)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8454912 [details] [diff] [review]
bug1028142.diff
Review of attachment 8454912 [details] [diff] [review]:
-----------------------------------------------------------------
If that is that simple, then that's great! Do you have tryserver access, though? I did try to fix myself such trivial cases, so I was sort of expecting that those for which I added HasDangerousPublicDestructor were not so trivial.
Attachment #8454912 -
Flags: feedback?(bjacob) → feedback+
Comment 3•10 years ago
|
||
This is just Anuj's patch rebased a tiny bit.
try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40
Attachment #8464355 -
Flags: review?(adam)
Comment 4•10 years ago
|
||
Comment on attachment 8464355 [details] [diff] [review]
Make the destructor of CSF::VideoControl private.
Review of attachment 8464355 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine. Thanks.
Attachment #8464355 -
Flags: review?(adam) → review+
Comment 5•10 years ago
|
||
Flags: needinfo?(rjesup)
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•