Closed
Bug 1028392
Opened 10 years ago
Closed 9 years ago
Address review comments from Bug 1027251
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: abr, Assigned: bjacob)
Details
The various approvals for the patches attached to Bug 1027251 included several that were conditional upon certain changes being addressed: https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c14 https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c17 https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c19 https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c25 I'm opening this bug for the purpose of addressing these review comments.
Assignee | ||
Comment 1•10 years ago
|
||
Ouch, it does seem that I forgot to address comment 25. The other comments listed above are addressed already, right?
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Benoit Jacob [:bjacob] from comment #1) > Ouch, it does seem that I forgot to address comment 25. The other comments > listed above are addressed already, right? Sorry -- I didn't audit the other patches. I found that my comments weren't addressed and assumed that we had a disconnect around the nature of reviews, not a simple "I forgot one" error. Thanks for the rapid response.
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•