Closed Bug 1028482 Opened 10 years ago Closed 10 years ago

Quitting inside WebIDE should actually quit

Categories

(DevTools Graveyard :: WebIDE, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 33

People

(Reporter: jryans, Assigned: paul)

References

Details

Attachments

(1 file)

This might be Mac specific, not sure. If WebIDE is open and is the active window (but there is also a regular Firefox window open), Cmd + Q will only close the WebIDE window. However, if you choose Quit from the menu bar, it does quit the entire app. Cmd + Q should always quit the entire app.
So what the best strategy? - Cmd-Q to quit Firefox - Cmd-W to quit WebIDE But Cmd-W is also used to close the running app (if connected to an app). We could use Ctrl-C to kill the running app, but Ctrl-C is used to copy text from projectEditor on Linux and Windows.
Flags: needinfo?(jryans)
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #1) > So what the best strategy? > > - Cmd-Q to quit Firefox > - Cmd-W to quit WebIDE Yes, these two make sense. We should always support the standard OS window / app management shortcuts, and that seems like the most reasonable way for them to function here. > But Cmd-W is also used to close the running app (if connected to an app). > We could use Ctrl-C to kill the running app, but Ctrl-C is used to copy text > from projectEditor on Linux and Windows. Oh wow, I hadn't noticed that Cmd+W was mapped to stop apps! I can't think of great replacement... but is "close app" even useful enough to need a shortcut? I would think "reinstall / refresh app" is much more useful, and that's already mapped to Cmd+R (which seems fine).
Flags: needinfo?(jryans)
Attached patch v1 (deleted) — Splinter Review
I haven't tested on osx. Ryan, can you make sure it works as expected?
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8444411 - Flags: review?(jryans)
Comment on attachment 8444411 [details] [diff] [review] v1 Review of attachment 8444411 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this seems to function correctly on OS X. Cmd+Q and Cmd+W both act as described in the comments above. ::: browser/devtools/webide/content/webide.xul @@ +43,5 @@ > <command id="cmd_toggleEditor" oncommand="Cmds.toggleEditors()" label="&viewMenu_toggleEditor_label;"/> > <command id="cmd_showAddons" oncommand="Cmds.showAddons()"/> > <command id="cmd_showTroubleShooting" oncommand="Cmds.showTroubleShooting()"/> > <command id="cmd_play" oncommand="Cmds.play()"/> > + <command id="cmd_stop" label="&projectMenu_stop_label;" oncommand="Cmds.stop()"/> Put the oncommand before the label to match the others.
Attachment #8444411 - Flags: review?(jryans) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
QA Whiteboard: [good first verify]
QA Whiteboard: [good first verify] → [qa+]
Verified as fixed using Firefox 33 beta 2 (20140908190852) under Mac OSX 10.9.4.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: