lalabelle03 Assignee
	Description • 10 years ago

User Agent: Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140620030201

Steps to reproduce:

I start Gaia in Firefox Nightly v.33.0a1 on my desktop.


Actual results:

The console logs the error : setCallingLineIdRestriction is not a function for the file 
telephony_settings.js 


Expected results:

The error should not exist.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 3 • 10 years ago

Comment on attachment 8443962 [details] [diff] [review]
1028544.patch

Review of attachment 8443962 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the following changes. Because you may not have the time to fix it, I took the liberty to fix it for you and push those changes against our CI.

See https://tbpl.mozilla.org/?tree=Gaia-Try&rev=4445d1ce81c2520ddbd0188d86cede54d024513d

If the CI is green I will merged this change. Thanks for it.

::: apps/system/js/telephony_settings.js
@@ +148,5 @@
>        };
>      },
>  
>      _setCallerIdPreference: function(conn, callerIdPreference, callback) {
> +      if(!conn.hasOwnProperty('setCallingLineIdRestriction')) {

To match the Gaia guidelines, instead of "if(", it should be "if ("

@@ +154,5 @@
> +          callback();
> +        }
> +        return;
> +      }
> +      

Extra whitespaces. This is likely your text editor that add them automatically.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 4 • 10 years ago

Gaia-Try complains but because there is a new perma-red related to Calendar. Let's land that.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 5 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/18e11d6dbb6b4363c517382083221d143d4997ef