The link toolbar background doesn't mesh in perfectly in Modern. It seems slightly darker than one would expect. cc'ing usual suspects as per bug 102832.

I think you're seeing things :-) We don't style this explicitly, so it shoul have (and does have, as far as I can see) the same background as the Personal Toolbar. Gerv

cool new feature! ->claudius, since he tests toolbars.

WORKSFORME 2001100303 win2k .... the background texture over here is exactly the same as the otehr toolbars...

That's the problem. In modern, the toolbars get progressively different shades (menu bar->nav bar->personal toolbar) but then you get the link bar which repeats one of the levels, and so looks ugly. If I disable my personal toolbar, of course, it all works perfectly. This could probably be fixed by making modern use one TALL background for the toolbars, and use fixed positioned backgrounds instead of having it attached to the toolbar each time. Should this bug go to hewitt?

Yes :-) Gerv

Reassigning to link toolbar usuals.

This was assinged to hewitt because it is perceived as a problem with the way Modern assigns colors to toolbars.

--> shliang We should just a solid color to generic toolbars which matches the lowest color of the gradient on the personal toolbar, then assign the current gradient background only to the personal toolbar (and the formatting toolbar in editor/mail compose). I know this isn't "scalable" with regards to hiding/showing toolbars and things lining up (and perhaps someday toolbar re-arranging), but the problem with Ian's fixed-position background idea is that the back/forward/reload/stop buttons need to be aligned just so with their background, and so if the text size were to grow, the menubar would then push these buttons down and they wouldn't line up. Of course, if we were free to use transparent PNGs this wouldn't be a problem ;)

Hewitt: I don't think there is a blanket ban on checking in PNG images into skins? I personally argued to get 2 into the Mac classic skin because there was no other way to get the effect required. I know in general we have avoided it because it did not work well last time we tried to convert the entire modern skin, but a few targeted PNGs where needed shouldn't present a problem? (besides, wasn't the last try at a png skin done with the old image library (ie, pre libpr0n)? Probably need to reassess whether its a real problem still or not)

Comment on attachment 54938 [details] [diff] [review] generic toolbars with solid background color sr=hewitt, but remove that commented out line, yo!

Comment on attachment 54938 [details] [diff] [review] generic toolbars with solid background color in toolbar.css patch, is that added comment necessary or can you remove the line completely?

Comment on attachment 54938 [details] [diff] [review] generic toolbars with solid background color r=andreww sans comment line.

checked in

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31. if you think this particular bug is not fixed, please make sure of the following before reopening: a. retest with a *recent* trunk build. b. query bugzilla to see if there's an existing, open bug (new, reopened, assigned) that covers your issue. c. if this does need to be reopened, make sure there are specific steps to reproduce (unless already provided and up-to-date). thanks! [set your search string in mail to "AmbassadorKoshNaranek" to filter out these messages.]