Peter La Reporter
	Description • 10 years ago

Currently, the notifications tray looks very confusing when you pull it down.  The transparency coupled with the segmentation caused by each notification's background rectangle makes the tray not 'read' as a single panel.

I propose a couple of small, low-effort tweaks that can vastly improve the experience of pulling down and using the notifications tray.  Please see attached spec for details.

This bug can be considered a sister bug to this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1022429

as they both work to align the notifications tray more with the visual refresh.  However, I would consider this one more important from a UX standpoint.

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 1 • 10 years ago

Assigning myself, would love to work on it!

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 2 • 10 years ago

Hey Alive, could you review this for me please?
Thanks

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 3 • 10 years ago

And the screenshot for UI review.

	Peter La Reporter
	Comment 4 • 10 years ago

Comment on attachment 8444836 [details]
Screenshot - After Patch

Hi Ahmed,

Thanks for taking on another one! :)  Everything looks great, except the baseline for the date is now one pixel too low when compared to the time.  If you can fix this, I'll give it a ui-review+.

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 5 • 10 years ago

It seems like another bug took care of the status bar date (seems like the font update just did it).
So I rebased, took off the status bar edit, and here's a new screenshot.

	Peter La Reporter
	Comment 6 • 10 years ago

Comment on attachment 8451201 [details]
Screenshot 2 - After Patch

Looks great!  Thank you!

	Peter La Reporter
	Comment 7 • 10 years ago

Ahmed, can you attach a link to the patch?

Alive, can you approval-b2g review+ it for 2.0?  This fix is pretty low risk, high reward.

Thanks!

	Ahmed Nefzaoui [:Nefzaoui] Assignee
	Comment 8 • 10 years ago

Sure,
We have attachment 8444830 [details] as a patch.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 9 • 10 years ago

Sorry I cannot approve, you should ask PM.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 10 • 10 years ago

Comment on attachment 8444830 [details]
Github pull-request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

See comment 7, asked by visual.

	bhavana bajaj [:bajaj]
	Comment 11 • 10 years ago

Comment on attachment 8444830 [details]
Github pull-request

low risk, css changes..

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 10 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/f445a1ac660d5ad4d710f2e88b4f693a9752c8f6

	Ryan VanderMeulen [:RyanVM]
	Comment 13 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/a867ab091d8f01b9c68f420ca97e880e06e25871