Closed Bug 1029336 Opened 10 years ago Closed 10 years ago

Only disable system items in context menu for certified apps

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S5 (4july)

People

(Reporter: sicking, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 2 obsolete files)

Right now we disable the "default items" in context menus for all apps. Only items explicitly added by apps are shown. This isn't really how context menus work elsewhere on the web. It would be good to align better with the web here. Apparently a bunch of our built-in apps aren't really prepared to deal with context menus right now though, so we should probably keep them disabled for certified apps. But it'd be good to avoid certified apps coming to rely on the lack of context menus.
We might want to make this depend on bug 1029343 so that we retain the ability for pages to do their own context menus using <menu>, like they can today.
Depends on: 1029343
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Assignee: nobody → dale
Attachment #8446703 - Attachment is obsolete: true
Attachment #8446703 - Flags: review?(alive)
Attachment #8446706 - Flags: review?(alive)
Apologies for the bugmail, noticed a few nits after settings review Didnt know whether isCertified or the current |if| would be better, but this matches current similiar checks, the test is basic but yay integrations tests and I have been adding to it in follow up bugs
Attachment #8446706 - Attachment is obsolete: true
Attachment #8446706 - Flags: review?(alive)
Attachment #8446710 - Flags: review?(alive)
Comment on attachment 8446710 [details] https://github.com/daleharvey/gaia/commit/0c869a1e7be5f8b1b4ec3b7889299c3d064bbd1a As you said, implement AppWindow.prototype.isCertified() makes more sense to me. Please have test and ask for review again if you feel need.
Attachment #8446710 - Flags: review?(alive) → review+
This both had a new integration test, an existing unit test failed due to the changed behaviour and added isCertified + a unit test for that, so I think its good without a new review, thanks landed in: https://github.com/mozilla-b2g/gaia/commit/163f259fc7c8a01e3265c050094767e3ad523b80
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
Status: RESOLVED → REOPENED
Flags: needinfo?(dale)
Resolution: FIXED → ---
Target Milestone: 2.0 S5 (4july) → ---
it worked locally, looks like a sandbox failure, probably needs added to the mock, apologies for the hassle, will do a try run first this time
Flags: needinfo?(dale)
Target Milestone: --- → 2.0 S5 (4july)
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: