Closed Bug 1029631 Opened 10 years ago Closed 8 years ago

Enable touch-action on Nightly for platforms that support touch events

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Version:
29 Branch
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: smaug, Assigned: kats)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [parity-IE] [parity-blink])

Attachments

(3 files)

Patch
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Bug 1029631 - Make a couple of gtests touch-action-friendly.
(deleted), text/x-review-board-request
botond
: review+
Details
Bug 1029631 - Add a missing null check.
(deleted), text/x-review-board-request
botond
: review+
Details
Blink will have touch-action enabled for touch events (but may not have pointer events). We should investigate if the current touch-action implementation works well enough with touch events, and once it does, enable touch-action on touch devices, at least. webkit bug to implement touch-action is https://bugs.webkit.org/show_bug.cgi?id=133112
Blocks: 960316
May you please provide an update on what is blocking this issue? Is it just Bug 1171098?
Whiteboard: [parity-IE] [parity-blink]
Mostly it's lack of time/resources. The touch-action implementation is not fully complete on the APZ side and nobody is actively working on it.
Stealing and repurposing. I think touch-action is good enough to turn on in Nightly now. I will be meeting with other vendors later this month and webcompat/interop of implementations will be one of the things we discuss. If all is well after that we can let it ride the trains in Fx 50 or (more likely) 51.
Assignee: nobody → bugmail
OS: Linux → All
Summary: Consider enabling touch-action on Android and FFOS for touch events → Consider enabling touch-action on Nightly for platforms that support touch events
Keywords: dev-doc-needed
Summary: Consider enabling touch-action on Nightly for platforms that support touch events → Enable touch-action on Nightly for platforms that support touch events
Attached patch Patch (deleted) — — Splinter Review
Attachment #8768141 - Flags: review?(bugs)
Comment on attachment 8768141 [details] [diff] [review] Patch Ok, so this is about Pointer Event v1 touch-action. We're missing the v2 additions. v1 https://www.w3.org/TR/pointerevents/#the-touch-action-css-property v2 https://w3c.github.io/pointerevents/#the-touch-action-css-property Assuming I'm testing this right on Chrome, it doesn't ship v2 values either by default yet.
Attachment #8768141 - Flags: review?(bugs) → review+
Could you please file a bug to implement the v2 stuff.
(In reply to Olli Pettay [:smaug] from comment #6) > Assuming I'm testing this right on Chrome, it doesn't ship v2 values either > by default yet. Yeah, they almost turned it on a few days ago but decided to wait [1]. (In reply to Olli Pettay [:smaug] from comment #7) > Could you please file a bug to implement the v2 stuff. Filed bug 1285685. [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VhYxkRlfQng
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f37f4fd841 Enable touch-action support on Nightly for all platforms. r=smaug
Whoops, sorry about that. Added a couple of patches that fix the test failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4764eba72fbf
Flags: needinfo?(bugmail)
Comment on attachment 8769454 [details] Bug 1029631 - Make a couple of gtests touch-action-friendly. https://reviewboard.mozilla.org/r/63358/#review60360
Attachment #8769454 - Flags: review?(botond) → review+
Comment on attachment 8769455 [details] Bug 1029631 - Add a missing null check. https://reviewboard.mozilla.org/r/63360/#review60362
Attachment #8769455 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/600f3ae078de Make a couple of gtests touch-action-friendly. r=botond https://hg.mozilla.org/integration/mozilla-inbound/rev/e16dbf89e07f Add a missing null check. r=botond https://hg.mozilla.org/integration/mozilla-inbound/rev/9157099559f4 Enable touch-action support on Nightly for all platforms. r=smaug
This is now listed on “Experimental features in Firefox” (https://developer.mozilla.org/en-US/Firefox/Experimental_features). Since it’s unclear if it will ride the train (please let me know if that changes), it will not be listed in the standard developer release notes until that decision is made. However, I’ve also updated the following page to note its availability in Nightly 50: https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent
Keywords: dev-doc-needed → dev-doc-complete
Thanks. There is a dev-doc-needed keyword on bug 1244402, so once this stuff is riding the trains presumably you'll get a notification from that even if I forget to let you know explicitly.
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: