Closed Bug 1029659 Opened 10 years ago Closed 10 years ago

[browser] X next to search bar appears oversized

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tif, Assigned: pivanov)

References

Details

Attachments

(4 files)

STR:
1. Launch Browser
2. Observe icon to the right of the text field

Expected
Icon appears to be normal size

Actual
Icon appears to be stretched
Assignee: nobody → pivanov
Blocks: 1016987
Attached image browser search (deleted) —
Attached file patch for Gaia/master (deleted) —
Attachment #8445351 - Flags: ui-review?(tshakespeare)
hmmm it's definitely smaller, but still appears fuzzy. I'm NI'ing Helen as we might need a new icon for this.

Thanks Pavel!
Flags: needinfo?(hhuang)
Attached image Shot from Device (deleted) —
Attachment #8445762 - Flags: ui-review?(tshakespeare)
Attached image browser (deleted) —
Your screenshot looks awesome! I don't know why mine doesn't look like that. I updated gaia/gecko today... :(

Gaia      57da30f405ba37a5d4844f32bb292271b81faee2
Gecko     https://hg.mozilla.org/mozilla-central/rev/a19e0434ea52
BuildID   20140625040202
Version   33.0a1
Comment on attachment 8445762 [details]
Shot from Device

This looks awesome and how it should be on the device. IDK why the patch doesn't work on mine :-/
Attachment #8445762 - Flags: ui-review?(tshakespeare) → ui-review+
Hi, 

I've checked files in Gaia, all the sizes for this icon are there. Also, the icon's size in the screenshot is correct!
Flags: needinfo?(hhuang)
Attachment #8445351 - Flags: review?(bfrancis)
Hey Tiffanie,
ping me on IRC to talk about how you test the patches and I will help you to do it correctly :)
Comment on attachment 8445351 [details]
patch for Gaia/master

Thanks Pavel
Attachment #8445351 - Flags: review?(bfrancis) → review+
Thanks Ben :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/7ea88fac0821ae644976520d0a0f2898e026690d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: