Closed
Bug 1029782
Opened 10 years ago
Closed 10 years ago
Have OPEN_SECRETLY flag for opening cache entries
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mayhemer, Assigned: mayhemer)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
This flag when specified should work the way to not update some of the "last-access" metadata on the entry, mainly frecency value.
Assignee | ||
Comment 1•10 years ago
|
||
Fetch count is currently implemented to count the number of fetches from disk, not the number of opens, which seems to me wrong. Also changing that logic would make implementing this flag easier.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Summary: Have OPEN_SECRET flag for opening cache entries → Have OPEN_SECRETLY flag for opening cache entries
Assignee | ||
Updated•10 years ago
|
Blocks: cache2polish
Updated•10 years ago
|
Assignee: honzab.moz → sworkman
Assignee | ||
Comment 4•10 years ago
|
||
- nsICacheStorage::OPEN_SECRETLY
- doesn't update frecency, last modified, last fetched and fetch count
- does update it when opening for write or revalidating (the secret concept doesn't make sense in that case)
Attachment #8445515 -
Attachment is obsolete: true
Attachment #8482932 -
Flags: review?(michal.novotny)
Comment 5•10 years ago
|
||
Comment on attachment 8482932 [details] [diff] [review]
v1
Review of attachment 8482932 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/test/unit/test_cache2-28a-OPEN_SECRETLY.js
@@ +4,5 @@
> + function NowSeconds() {
> + return parseInt((new Date()).getTime() / 1000);
> + }
> + function do_check_time(a, b) {
> + do_check_true(Math.abs(a - b) < 0.5);
The same as in bug 1000338 comment 5.
Attachment #8482932 -
Flags: review?(michal.novotny) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8482932 -
Attachment is obsolete: true
Attachment #8487802 -
Flags: review+
Assignee | ||
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
sorry had to back this out for xpcshell bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=47869769&tree=Mozilla-Inbound
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #9)
> sorry had to back this out for xpcshell bustage like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=47869769&tree=Mozilla-
> Inbound
Didn't show on try... Will check.
Assignee | ||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•