Closed Bug 1029989 Opened 10 years ago Closed 10 years ago

Rename private_tabs_panel_description to reflect new string content

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 33

People

(Reporter: flod, Assigned: mcomella)

References

Details

Attachments

(1 file)

Update empty private tabs page entity name.
(deleted), patch
wesj
: review+
Details | Diff | Splinter Review
This is not OK http://hg.mozilla.org/mozilla-central/rev/0f335eff972f I'd be fine with the change "any form of" -> "any of", not with the addition of "bookmarks". https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings
Oh, nice catch - sorry about that. This string is currently only in Nightly (33) and the original string landed in Nightly a week prior to the change (both in the same bug). Should the entity name still be updated? Are the strings pushed to the localizer's tools as soon as the entity lands in m-c?
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Flags: needinfo?(francesco.lodolo)
If it landed on master, yes, you need a new ID (it's marked as untranslated as soon as it lands on mozilla-central).
Flags: needinfo?(francesco.lodolo)
Attachment #8446078 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/6fe53d58d0ae
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: