Currently, Windows has a couple of theme issues related to the webIDE : - Strange borders on the menu item hover and active state (due to xul.css on Windows I think) - Wrong font on project page - Native hover and active state on main toolbar buttons (we might want to use project chameleon's buttons)

What should I do for the last issue ? (I'm gonna provide a screen in case you're reading this early)

(In reply to Tim Nguyen [:ntim] from comment #1) > What should I do for the last issue ? (I'm gonna provide a screen in case > you're reading this early) I'd try to add background: transparent to one of these selectors in webide.css to see if they are applying in this case (these are the states we have set for devtools-toolbarbuttons and this is a toolbarbutton as well). .panel-button:hover .panel-button:hover:active .panel-button[open=true] .panel-button[checked=true] If none of those fix it, maybe we just need to set background: transparent on the panel-button class itself.

(In reply to Tim Nguyen [:ntim] from comment #0) > Currently, Windows has a couple of theme issues related to the webIDE : > - Strange borders on the menu item hover and active state (due to xul.css on > Windows I think) Right. We probably need to use: > .panel-item { border-width: 0 } > - Wrong font on project page Can you elaborate? > - Native hover and active state on main toolbar buttons (we might want to > use project chameleon's buttons) Is that bad? We have that on Linux as well. I don't use Windows, do you think you can try to write a patch to address these issues?

This fixes all issues, although, I haven't tested the patch yet.

Comment on attachment 8445911 [details] [diff] [review] Patch v1 Review of attachment 8445911 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Tim Nguyen [:ntim] from comment #6) > Created attachment 8445911 [details] [diff] [review] > Patch v1 > > This fixes all issues, although, I haven't tested the patch yet. The code changes look generally fine, but please test on Windows to confirm ::: browser/devtools/webide/themes/details.css @@ -4,5 @@ > > body { > margin: 0; > background-color: white; > - font-family: Lucida Grande, Helvetica, Helvetica Neue, sans-serif; I'm not sure about this.. Paul, what do you think about changing this font to message-box? I'm assuming it was this stack for a reason

We're quite inconsistent with fonts. We use the system font nearly everywhere and the mac system font on the details pane. Seems strange to me.

Tim, ping me on IRC.

(for the next patch, I'd like to review the code)

Comment on attachment 8445911 [details] [diff] [review] Patch v1 I've just tested the patch, and it works fine.

Comment on attachment 8445911 [details] [diff] [review] Patch v1 Nothing changed on Mac (good!), and it looks better on Linux (very good!).

Reproduced the initial issue on old Nightly (2014-06-25), verified that the layout issue is fixed on Windows 7 64bit and Windows 8.1 64bit using Firefox 33 beta 2.