STR: 1. Using the screen reader, select a contact entry. 2. Navigate to the SMS button next to the phone entry. Expected: the screen reader announced the SMS button Observed: the screen reader just says 'button'

Re-aligning priorities with 2.1 accessibility goals.

Hi, I am interested in working on this bug. Has anyone been assigned by far? if not, could you please assign this bug to me?

Evelyn, Vincent (exsequens15@gmail.com) is my member, if you think it's an appropriate bug for the first "good-first-bug", please assign this to him. Thanks.

Thanks. Vincent will be working on this bug.

i tried to open Screen Reader but couldn't find it. i'm not sure if it's a correct way to open Screen Reader. Settings->Device information->More information->Developer",select "Screen reader". when i went into More Information, there's no Developer, only Developer Menu, and if i went into Developer appeared after checking the checkbox, there's nothing looks like Screen Reader. is there anyone who can give me some hint about it?

hi yzenevich, do you have any suggestions?

(In reply to exsequens15 from comment #5) > i tried to open Screen Reader but couldn't find it. > > i'm not sure if it's a correct way to open Screen Reader. > Settings->Device information->More information->Developer",select "Screen > reader". > > when i went into More Information, there's no Developer, only Developer > Menu, and if i went into Developer appeared after checking the checkbox, > there's nothing looks like Screen Reader. > > is there anyone who can give me some hint about it? Hi Vincent (please use needinfo? next time or chances are I will miss your comment). You can try/use the screen reader(SR) 2 ways: on the phone itself or with Gaia and Firefox for desktop (easier for beginners). If you run Gaia in Firefox for desktop, you should notice a number of tools on the right hand side. One of the tabs there is the SR simulator tab. If you click there you can start and stop the SR. It will not actually talk with Nightly because the synthesizer is not bundled with it, but you will see the text of what the SR would say. To use it you can either use controls within that tab (swipe, double swipe in all directions as well as the double click button). You can use the same interaction on the screen itself.

Hi Vincent, do you need any more pointers with how to proceed?

(In reply to Yura Zenevich [:yzen] from comment #8) > Hi Vincent, do you need any more pointers with how to proceed? thanks, Yura, i've already solved the bug and now i'm working on the progress of submitting the patch.

PR URL: https://github.com/mozilla-b2g/gaia/pull/22507

Comment on attachment 8467574 [details] [diff] [review] 0001-Bug-1030411-Fix-the-unlabeled-SMS-button.patch >From 012141faabf282f5e9b7ac617144e1014b655a23 Mon Sep 17 00:00:00 2001 >From: llewellin <exsequens15@gmail.com> >Date: Wed, 30 Jul 2014 16:54:11 +0800 >Subject: [PATCH] Bug 1030411 - Fix the unlabeled SMS button. > >--- > apps/communications/contacts/elements/details.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/apps/communications/contacts/elements/details.html b/apps/communications/contacts/elements/details.html >index 2e27a6b..c7494f4 100644 >--- a/apps/communications/contacts/elements/details.html >+++ b/apps/communications/contacts/elements/details.html >@@ -15,7 +15,7 @@ > <h2 data-l10n-id="#type_l10n_id#">#type# <span class="carrier">#carrier#</span></h2> > <div class="item"> > <div class="item-media pull-right"> >- <button id="send-sms-button-#i#" class="activity send-sms icon icon-message"></button> >+ <button id="send-sms-button-#i#" class="activity send-sms icon icon-message"><span>SMS</span></button> > </div> > <div class="item-body-exp"> > <button class="activity call-action icon icon-call" id="call-or-pick-#i#"> >-- >1.7.9.5 >

Hi Vincent, thanks for the pull request. You can just attach an URL to the pull request as a patch without the need of making an actual patch file (see here http://globau.wordpress.com/2013/10/21/github-pull-requests-and-bugzilla/). Also please mark me for a11y-review along with the actual module owner/reviewer as it is an accessibility bug. In regards to the patch itself, you don't need to add a span with text inside the button (since we do not want it visible to all users). You need to use a data-l10n-id attribute and assign aria label so it can also me localized. See the dialer app for example.

i see, thanks for your kindly help, Yura. the text inside span tag won't show up for CSS property has already made it invisible. i know aria label is used for the text for ScreenReader, but how about data-l10n-id? i know it's for Localization, so what you mean is that i need to add the tag and edit .properties files myself?

(In reply to exsequens15 from comment #13) > i see, thanks for your kindly help, Yura. > the text inside span tag won't show up for CSS property has already made it > invisible. Ya, that's something to avoid when doing accessibility. Things should be invisible to both sighted and screen reader users. > > i know aria label is used for the text for ScreenReader, but how about > data-l10n-id? i know it's for Localization, so what you mean is that i need > to add the tag and edit .properties files myself? Correct, data-l10n-id used to look up a string in the message properties file. To use it for aria label, the key in the properties file should be something like: yourbutton.ariaLabel = {Actual aria label text}. The l10n framework will know to put the string in place for aria-label attribute and not the inner HTML.

Comment on attachment 8467574 [details] [diff] [review] 0001-Bug-1030411-Fix-the-unlabeled-SMS-button.patch This is actually in the "Contacts" app, redirecting to a proper peer :)

Comment on attachment 8467574 [details] [diff] [review] 0001-Bug-1030411-Fix-the-unlabeled-SMS-button.patch Just to get this moving, a11y-r- for now based on the comments in the bug.

i know how to fix it now, but the Simulator doesn't work for these four days, probably because of the Nightly version. could you teach me how to use simulator on device? thanks.

(In reply to exsequens15 from comment #17) > i know how to fix it now, but the Simulator doesn't work for these four > days, probably because of the Nightly version. could you teach me how to use > simulator on device? thanks. So the simulator should be working again as soon as the latest version is approved on addons.mozilla.org. If you would like to test it on the actual device you can enable/disable the screen reader by doing the following sequence 6 times: volume up + volume down (after the first 3 times you should hear the instructions to do it 3 more times). You can then navigate Gaia with the screen reader by touching and holding the areas on the screen to focus and double tapping to activate things. To swipe you need to use 2 fingers at once instead of one.

(In reply to exsequens15 from comment #17) > i know how to fix it now, but the Simulator doesn't work for these four > days, probably because of the Nightly version. could you teach me how to use > simulator on device? thanks. FYI should be working now.

Comment on attachment 8467574 [details] [diff] [review] 0001-Bug-1030411-Fix-the-unlabeled-SMS-button.patch Removing the r? until we get the a11y-review+ from yzenevich. Please ask for r? again once the comments on gh are addressed. Thanks!

Hi Vincent, any luck with this bug?

De assigning.

Hi there. I made a pull request for this bug. Please let me know if it looks OK or I need to change anything. I would love to take over this bug if no one is working on it.

Comment on attachment 8478251 [details] pull request Works well with the screen reader. Forwarding to the module owner. Thanks!

Comment on attachment 8478251 [details] pull request Thanks for the contribution!

Landed, removing keyword.