STR: 1. Switch to French 2. Create a new "All day" event 3. Go to month view 4. Select the day for which the even has been created Actual result: "All Day" is displayed in English Expected result: "All Day" is displayed in French Added qawanted to test on 2.0 Tested on Flame 2.1 Gaia 1bcd355855626640b2532f2ccb1f814711f7a6ad Gecko https://hg.mozilla.org/mozilla-central/rev/da1dbcff9493 BuildID 20140625160202 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014

Hard-coded "All day" https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/templates/months_day.js#L21

While the localizability issue seems easy to solve, at least on master (assign data-l10n-id="hour-allday"). This is what happens when the string is long (in this case, "Sepanjang Hari" from ms). So there's also a layout issue.

(In reply to Francesco Lodolo [:flod] from comment #2) > This is what happens when the string is long (in this case, "Sepanjang Hari" > from ms). So there's also a layout issue. For French, my current translation ("Journée") is really poor, it should be "Toute la journée", so I agree we can do something here :)

Yes. Mine is "Giorno int." instead of "Giorno intero" or "Intera giornata". With the current layout I don't think we're using "hour-allday" anywhere besides this view, since other views have the 24 icon.

Removing late-l10n, this patch is not adding a new string (we already have the string localized in l10n file)

Comment on attachment 8446578 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21056 Just one food for thought level comment. Thanks miller!

This bug repro's on: Flame 2.1 Master, Flame 2.0, OpenC 2.1 Master, OpenC 2.0, Buri 2.1 Master, Buri 2.0 Actual Results: All Day events in Calendar for French show up as All Day instead of being translated. Environmental Variables: Device: Flame Master Build ID: 20140626063403 Gaia: 87a7746568ac5708e828026160c0732ba252300f Gecko: 4c9d8c885791 Version: 33.0a1 (Master) Firmware Version: v122 ------------------------------------------ Environmental Variables: Device: Flame 2.0 Build ID: 20140626060203 Gaia: d815bfbb70d0f4a3757bb9eb93956a59a103d181 Gecko: cfa9446d0960 Version: 32.0a2 (2.0) Firmware Version: v122 ------------------------------------------ Environmental Variables: Device: Open_C Master Build ID: 20140626063403 Gaia: 87a7746568ac5708e828026160c0732ba252300f Gecko: 4c9d8c885791 Version: 33.0a1 (Master) Firmware Version: P821A10V1.0.0B06_LOG_DL ------------------------------------------ Environmental Variables: Device: Open_C 2.0 Build ID: 20140626095753 Gaia: 34f4b94233a0e03ffbb3b84dc0ed1cc52df1df1a Gecko: 0356c34ec908 Version: 32.0a2 (2.0) Firmware Version: P821A10V1.0.0B06_LOG_DL ------------------------------------------ Environmental Variables: Device: Buri Master Build ID: 20140626063403 Gaia: 87a7746568ac5708e828026160c0732ba252300f Gecko: 4c9d8c885791 Version: 33.0a1 (Master) Firmware Version: v1.2device.cfg ------------------------------------------ Environmental Variables: Device: Buri 2.0 Build ID: 20140626113947 Gaia: 34f4b94233a0e03ffbb3b84dc0ed1cc52df1df1a Gecko: 8eff2a44f2b2 Version: 32.0a2 (2.0) Firmware Version: v1.2device.cfg ------------------------------------------ This bug does NOT repro on: Flame 1.4, OpenC 1.4, Buri 1.4 Actual Result: All Day in French is translated properly for Calendar. Environmental Variables: Device: Flame 1.4 Build ID: 20140625000201 Gaia: c9416de14acf9e94ab006619cd2418c768422fcb Gecko: cddf88f78632 Version: 30.0 (1.4) Firmware Version: v122 ------------------------------------------- Environmental Variables: Device: Open_C 1.4 Build ID: 20140625000201 Gaia: c9416de14acf9e94ab006619cd2418c768422fcb Gecko: cddf88f78632 Version: 30.0 (1.4) Firmware Version: P821A10V1.0.0B06_LOG_DL ------------------------------------------- Environmental Variables: Device: Buri 1.4 Build ID: 20140626114544 Gaia: 2f4acc16a99d40cf18d78fe51e14f1ea63b837c2 Gecko: 236ef7ae3260 Version: 30.0 (1.4) Firmware Version: v1.2device.cfg

landed on master: https://github.com/mozilla-b2g/gaia/commit/464e616b5caeef16fd03125385789df969dc86c7

Miller, should I file a different bug for the layout problem?

Yes Francesco, will need to ask for UI approval and wanted to get this landed so that I could fix other L10n bugs. Thanks!

v2.0: https://github.com/mozilla-b2g/gaia/commit/f7f067b0652ed36c740d6f21bc587db54602642d

backed out the patch on branch v2.0 since it introduced Bug 1033232: https://github.com/mozilla-b2g/gaia/commit/d2e6f32788bb28781fd1484d190f78b98464d31c

this should fix 2.0, added a call to navigator.mozL10n.get('hour-allday') to make sure it's displayed. L10n behavior is different on v2.0 and v2.1 :/

(In reply to Miller Medeiros [:millermedeiros] from comment #14) > L10n behavior is different on v2.0 and v2.1 :/ Probably bug 992473.

Comment on attachment 8449491 [details] Link to Github pull-request [branch v2.0]: https://github.com/mozilla-b2g/gaia/pull/21287 LGTM!

landed on v2.0: https://github.com/mozilla-b2g/gaia/commit/73bcb7bef5fa88859074e32306bd0b194cd116b1

[Environment] Gaia 0910be495385d90acdeaddbeaf1fba315aff57b0 Gecko https://hg.mozilla.org/mozilla-central/rev/7883d8e9f210 BuildID 20140715160202 Version 33.0a1 ro.build.version.incremental=94 ro.build.date=Tue May 20 09:29:20 CST 2014 [Result] Pass

This issue has been successfully verified on Flame 2.0: Gaia-Rev 99e4594c66aa3738d58b0cb44bd885a87a063b6e Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f91abc6127d9 Build-ID 20141125000201 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6 Build-ID 20141125001201 Version 34.0 Device-Name flame FW-Release 4.4.2