Open
Bug 103069
Opened 23 years ago
Updated 2 years ago
context menu shifts on dismissal
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
NEW
Future
People
(Reporter: dean_tessman, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
yuanyi21
:
review+
|
Details | Diff | Splinter Review |
This may have already been filed, perhaps even by me, but I can't find it.
Steps to reproduce:
1. Find an old, slow computer like my PII-350
2. Start Composer
3. Right-click to display the context menu over top of Edit Mode Toolbar
4. Note that there are four menu items
5. Press Esc
6. Watch closely
Expected Results: menu dismisses
Actual Results: menu jumps up a bunch and then dismisses
I only ever see this with the context menu in Composer.
Comment 1•23 years ago
|
||
over to editor
Assignee: ducarroz → syd
Component: Composition → Editor: Composer
Product: MailNews → Browser
QA Contact: sheelar → sujay
Reporter | ||
Comment 2•23 years ago
|
||
This also only happens if I dismiss the menu using Esc. If I dismiss it with a
left button press, no jumpiness.
Reporter | ||
Comment 3•23 years ago
|
||
I wonder if this is related to bug 105698 in some weird way?
I see this bug in the browser - build 2001122106, win98, PII/350MHz
...forgot to mention, I have seen this menu-jump when the manu is dismissed by
*any means* - hit Esc, click somewhere outside the menu, or click on a menu item.
I, too, have noticed it in Browser, PII 333.
Happens in case:
1) right click
2) hold button
3) move pointer
4) release button
5) dismiss context menu
Doesn't happen in case:
1) right click
2) do NOT move the mouse between mousedown and mouseup
3) dismiss context menu
See last comment for bug 105698. Probably, the nature of both bugs are the same.
Updated•23 years ago
|
Keywords: mozilla1.0,
nsbeta1
Comment 8•23 years ago
|
||
*** Bug 144015 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 9•23 years ago
|
||
--> XPMenus based on dupe bug 144015
Assignee: syd → hyatt
Status: ASSIGNED → NEW
Component: Editor: Composer → XP Toolkit/Widgets: Menus
QA Contact: sujay → shrir
Comment 10•23 years ago
|
||
bringing over cc: list from my dup
Comment 12•23 years ago
|
||
Here's what I get:
XXX Damage rectangle (38,4237,3477,19) does not intersect the widget's view
(0,0,3477,4218)!
###!!! ASSERTION: ACK, BAD TARGET NODE: 'targetNode', file nsMenuPopupFrame.cpp,
line 600
###!!! Break: at file nsMenuPopupFrame.cpp, line 600
###!!! ASSERTION: ACK, BAD TARGET: 'targetDocumentWidget', file
nsMenuPopupFrame.cpp, line 623
###!!! Break: at file nsMenuPopupFrame.cpp, line 623
This is the output of m1rc2 (Linux, self compiled) after:
1. Right click in the browser window
2. Move the mouse cursor down and up again through the popup menu
3. Press ESC
Comment 13•23 years ago
|
||
I don't see this anymore on build 2002051908-trunk, win98!
Fixed somehow?
Comment 14•23 years ago
|
||
The code that threw the assert in question two posts above was changed the other
day under bug 143607, one of the effects of that bug was the duplicate menu
issue this bug was all about... propose therefore we dup this (and possibly
105698) to 143607 and call it closed.
people to thank for the fix: p=bryner r=hewitt sr=jst a=shaver, none of whom are
on either of these bugs. :)
Comment 15•23 years ago
|
||
This bug is fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 16•23 years ago
|
||
No it's not. I can still reproduce using the original steps with build
2002060308 on Win2K.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment 17•23 years ago
|
||
Yeah, you're right. I think it's fixed in navigator though.
Comment 19•23 years ago
|
||
Comment 20•23 years ago
|
||
cmanske:
Why do we need EditorCleanupContextMenu? It causes the hidden menuitems to get
appeared again. In fact, they are not shown on screen, but are calculated when
the popup menu is reflowing. So the popup menu becomes larger and wider, and
jumps if its new frame can't be located completely within the screen.
Are there any disadvantages if we leave hidden and contexthidden attribute here?
Updated•23 years ago
|
Keywords: mozilla1.0 → mozilla1.1
Comment 21•23 years ago
|
||
Attachment #92090 -
Attachment is obsolete: true
Comment 22•23 years ago
|
||
I've always wondered what purpose this served! I vote for ripping out
EditorCleanupContextMenu() and ShowHiddenItemOnCleanup() entirely!
When we create a context menu, we always recalculate the enable/disabled states
and show/hide items appropriately. I don't think we need any "cleanup."
Comment 23•23 years ago
|
||
Comment 24•23 years ago
|
||
Comment on attachment 92306 [details] [diff] [review]
Suggestion to remove all cleanup code
r=kyle
cmanske's change is ok to me.
Attachment #92306 -
Flags: review+
Attachment #92118 -
Attachment is obsolete: true
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: shrir → xptoolkit.widgets
Comment 26•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: cmanske → nobody
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•