I've removed some unnecessary stuff from the Homescreen (so it doesn't for example have any Smart collections atm). Pressing long on the Homescreen there is the menu from which one could add new Smart Collections. Clicking that gives a list of collections. However selecting any of them and pressing OK doesn't add anything to the Homescreen.

Olli - Can you indicate what build ID & FxOS version you are testing with?

(In reply to Jason Smith [:jsmith] from comment #1) > Olli - Can you indicate what build ID & FxOS version you are testing with? Oh wait, I saw the version in the title. So I just need the build ID.

QA Wanted to see someone else can confirm. If confirmed on 2.1, then check to see if this happens on 2.0.

Note, at some point the smartcollection showed up in the homescreen (after installing new apps?), and once there was one smartcollection adding more worked. So it looks like one needs to remove all the existing smartcollections and then try adding a new one. Build id: 20140625160202

This bug repro's on: Flame 2.1 Master Actual Results: Attempting to add 1 or more collections to the homescreen will fail to show the added collections. Environmental Variables: Device: Flame Master Build ID: 20140627093529 Gaia: b8f36518696f3191a56e4f33447ee9d6ec820da1 Gecko: c90b38c47a1d Version: 33.0a1 (Master) Firmware Version: v122 --------------------------------------- --------------------------------------- This bug does NOT repro on: Flame 2.0, Buri 2.1, OpenC 2.1 Actual Result: Attempting to add 1 or more collections to the homescreen results in the collections appearing correctly. Environmental Variables: Device: Flame 2.0 Build ID: 20140627101328 Gaia: 553c9ce714e72d9e8a2bb97bfb56bf508ca7964b Gecko: 439a731c4267 Version: 32.0a2 (2.0) Firmware Version: v122 --------------------------------------- Environmental Variables: Device: Buri Master Build ID: 20140627093529 Gaia: b8f36518696f3191a56e4f33447ee9d6ec820da1 Gecko: c90b38c47a1d Version: 33.0a1 (Master) Firmware Version: v1.2device.cfg --------------------------------------- Environmental Variables: Device: Open_C Master Build ID: 20140627093529 Gaia: b8f36518696f3191a56e4f33447ee9d6ec820da1 Gecko: c90b38c47a1d Version: 33.0a1 (Master) Firmware Version: P821A10V1.0.0B06_LOG_DL

regression from 2.1 to 2.0, nomming as a blocker as smart collections are a major feature.

Currently unable to reproduce running the latest gaia master (35ca14719bf894a3b57be5596bc8e14cd2336935). If anyone could provide a logcat it would be very useful.

QA-Wanted for comment 7 - logcat in the latest gaia master

I could NOT reproduce this bug on the reported build (20140625160202), I then discussed to croesch at comment 5 who did the branch check, and he couldn't repro the bug on 2.1 again either. Is it possible that you had hit the home button immediately after you hit OK on add collection screen? If so, then it's another bug that has been filed. Please refer to bug 1029840. Croesch had confirmed that he very likely had intuitively hit Home button after adding a collection which triggered bug 1029840. Please clarify on the STR so we could progress on this bug.

Make sure you don't have any Smart Collections in the Homescreen. Press-long on the background. [Change Wallpaper] | [Add Smart Collections] menu opens. Click [Add Smart Collections], Click [Movies], Click [OK]. Homescreen shows up again, but there are no Smart Collections.

(I tested whatever was the latest update today.)

I made a video following exactly comment 10's repro steps on 6/28's build with NO repro. Video: http://youtu.be/jz3cmNeNA2k At comment 9 I tried 10 times with no repro, and for this comment I tried 3 times, each time resetting phone to Factory settings, and still no repro. Tested on: Device: Flame Build ID: 20140628040201 Gaia: b3324d031fe91b864090461ffcacc6ca605a2903 Gecko: 6ee5583b0fa6 Version: 33.0a1 (Master) Firmware Version: B1TC00011220

We have researched this bug a little deeper and have found out how to get this bug to occur. 1. Reset device. 2. On homescreen longpress and choose add collection option. 3. DENY sharing Geolocation (IMPORTANT!!) 4. Choose a collection and tap OK. 5. Notice the collection does not appear on the homescreen. This bug repro's on: Flame 2.1 Master, Flame 2.0, OpenC 2.1 Actual Results: Denying Geolocation before adding a collection causes the collection the user tries to add, not to appear on the homescreen. Environmental Variables: Device: Flame Master Build ID: 20140630063630 Gaia: bc3bbf42d2a606f6b7038881cff5ec3795fdf953 Gecko: 3b46de297f3f Version: 33.0a1 (Master) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Flame 2.0 Build ID: 20140630085228 Gaia: 564ab3935206a6979b317597020f47aebe8c80fe Gecko: 7974d58adda4 Version: 32.0a2 (2.0) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Open_C Master Build ID: 20140630063630 Gaia: bc3bbf42d2a606f6b7038881cff5ec3795fdf953 Gecko: 3b46de297f3f Version: 33.0a1 (Master) Firmware Version: P821A10V1.0.0B06_LOG_DL --------------------------------------------- ----------------------------------------------- ----------------------------------------------- This bug does NOT repro on: Flame 1.4, Buri 2.1 Actual Result: No Geolocation window appears when going into Collections for v1.4 devices, so bug cannot happen in this manner. Bug does not occur on the Buri device. Environmental Variables: Device: Flame 1.4 Build ID: 20140629211929 Gaia: aa896d5db1b4929f3bf31a0f4bb7de50530222a8 Gecko: 8cba60bc12ef Version: 30.0 (1.4) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Buri Master Build ID: 20140630063630 Gaia: bc3bbf42d2a606f6b7038881cff5ec3795fdf953 Gecko: 3b46de297f3f Version: 33.0a1 (Master) Firmware Version: v1.2device.cfg

Sounds right. I tend deny geolocation from apps which I think shouldn't use it. (So, I only allow it for Here or so)

I tried and I am able to reproduce this with a fresh "reset-gaia", but not after a reboot of the device. I also verified that the geolocation permission does not matter. I also tried an OTA update, and was unable to reproduce. So after an OTA update or device reboot I can not reproduce. croesch - You mentioned after a reset of the device, exactly how did you reset the device? We need to understand if a user can get into this scenario, or if it's due to something like restarting the b2g process through ADB.

Andrea - I have a hunch that datastore is not initialized properly after a restart of the b2g process (compared to a full phone restart). Do you think something like this is possible? Anything that might ring a bell? Thanks!

switching my nom from 2.1 to 2.0

(In reply to Kevin Grandon :kgrandon from comment #15) > I tried and I am able to reproduce this with a fresh "reset-gaia", but not > after a reboot of the device. I also verified that the geolocation > permission does not matter. > > I also tried an OTA update, and was unable to reproduce. So after an OTA > update or device reboot I can not reproduce. > > croesch - You mentioned after a reset of the device, exactly how did you > reset the device? We need to understand if a user can get into this > scenario, or if it's due to something like restarting the b2g process > through ADB. By resetting the device, I do this through Settings-> Device Information-> More Information-> Reset Phone

Don't need a window since this is an issue with the new homescreen implementation.

I've confirmed that this is caused by the fact that we are able to save the collections in the datastore, but we do not receive added/updated datastore events in the homescreen. This appears to only happen after a b2g process restart, and not a full phone reboot. (I have not seen it fail yet after rebooting the entire device). Renaming the bug to a more specific problem that is being surfaced by datastore and changing component to get the proper eyes on it.

(In reply to Kevin Grandon :kgrandon from comment #20) > I've confirmed that this is caused by the fact that we are able to save the > collections in the datastore, but we do not receive added/updated datastore > events in the homescreen. This appears to only happen after a b2g process > restart, and not a full phone reboot. (I have not seen it fail yet after > rebooting the entire device). > > Renaming the bug to a more specific problem that is being surfaced by > datastore and changing component to get the proper eyes on it. While looking at this bug I found bug 1032829 - where the added/updated events are received but nothing happens because we are adding collections to the pending list. I wonder if this is not the root cause of what Smaug is seeing. Smaug, do you remember if you have try to add a collection, and cancel the list without having choose any of the items at some point ?

I probably have cancelled at some point, most probably when I first time discovered "Add Smart Collections"

I don't think this would be the case as it happens directly after a reset-gaia or a factory reset. One thing that comes to mind could possibly be the creation process from FTU is doing something weird, I will do some more debugging today.

(In reply to Kevin Grandon :kgrandon from comment #23) > I don't think this would be the case as it happens directly after a > reset-gaia or a factory reset. One thing that comes to mind could possibly > be the creation process from FTU is doing something weird, I will do some > more debugging today. Could be a separate issue. Seems like https://bugzilla.mozilla.org/show_bug.cgi?id=1030700#c13 is different than the original issue (I don't think smaug is playing with Factory Reset ;)). Anyway since I opened a separate bug with a patch, I don't mind about bugmorphing this bug if needed.

(I haven't played with factory reset.)

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #21) > (In reply to Kevin Grandon :kgrandon from comment #20) > > I've confirmed that this is caused by the fact that we are able to save the > > collections in the datastore, but we do not receive added/updated datastore > > events in the homescreen. This appears to only happen after a b2g process > > restart, and not a full phone reboot. (I have not seen it fail yet after > > rebooting the entire device). > > > > Renaming the bug to a more specific problem that is being surfaced by > > datastore and changing component to get the proper eyes on it. > > While looking at this bug I found bug 1032829 - where the added/updated > events are received but nothing happens because we are adding collections to > the pending list. I wonder if this is not the root cause of what Smaug is > seeing. I also found bug 1032885, which steal the focus from the app when the user try to touch the permission prompt, resulting into the same corruption than bug 1032829, as the focus is dismissed and the select returns |false|.

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #26) > I also found bug 1032885, which steal the focus from the app when the user > try to touch the permission prompt, resulting into the same corruption than > bug 1032829, as the focus is dismissed and the select returns |false|. Nice find. That does seem like it could be the likely culprit? Changing components back while we investigate more to not waste cycles.

Confirmed, this is fixed with bug 1032885 and bug 1032829.

Is is possible for QA to retry to see if it still happens now that some of the dependencies has been fixed ?

I was able to reproduce this, and verified that the dependent bugs fixed this for me. Going to mark as fixed for now, but let's definitely let qa/:smaug verify this. (Note that the patches are currently only on the latest master, but will hopefully be uplifted soon)

Dependent bugs have been uplifted, and this should be fixed in the next daily build.

Verified that this bug is fixed in the following build: Environmental Variables: Device: Flame Master Build ID: 20140701173553 Gaia: 85e97290431ce6aa0a965421e84d6070cd899129 Gecko: 7075808c3306 Version: 33.0a1 (Master) Firmware Version: v122

This issue has been successfully verified on Flame 2.1&2.0. See attachment: verified_v2.1.mp4. Reproducing rate: 0/5 1. Connect Wifi. 2. Remove a collection from homescreen,or not. 3. Long press on homescreen and choose "Add Smart Collections". 4. DENY sharing Geolocation. 5. Choose one or two collections and tap "OK". **The collections will appear on homescreen. Flame 2.1 build: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141201.034405 FW-Date Mon Dec 1 03:44:15 EST 2014 Bootloader L1TC00011880 Flame 2.0 build: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141201000201 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141201.034308 FW-Date Mon Dec 1 03:43:18 EST 2014 Bootloader L1TC00011880