Closed
Bug 1031185
Opened 10 years ago
Closed 10 years ago
[Bluetooth] Port bug 1027030 to bluetooth2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
(Whiteboard: webbt-api)
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
No functional changes from bug 1027030.
No rebase changes from bug 1027030.
Attachment #8447023 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•10 years ago
|
||
No functional changes since bug 1027030.
Simple rebase changes since bug 1027030.
Attachment #8447024 -
Flags: review?(btian)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8447023 [details] [diff] [review]
[01] Bug 1031185: Wrap Bluedroid interfaces in classes
Review of attachment 8447023 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nit addressed. Thanks.
::: dom/bluetooth2/bluedroid/BluetoothInterface.cpp
@@ +364,5 @@
> +#else
> + return BT_STATUS_UNSUPPORTED;
> +#endif
> +}
> +#endif
nit: Add comment to match #if.
#endif // #if ANDROID_VERSION >= 18
Attachment #8447023 -
Flags: review?(btian) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8447024 [details] [diff] [review]
[02] Bug 1031185: Convert Bluetooth to use Bluedroid wrappers
Review of attachment 8447024 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nits addressed. Thanks.
::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +21,4 @@
> #include "BluetoothA2dpManager.h"
> #include "BluetoothHfpManager.h"
> #include "BluetoothOppManager.h"
> +#include "BluetoothInterface.h"
nit: alphabetical order.
::: dom/bluetooth2/bluedroid/BluetoothSocket.cpp
@@ +10,5 @@
> #include <sys/socket.h>
>
> #include "base/message_loop.h"
> #include "BluetoothSocketObserver.h"
> +#include "BluetoothInterface.h"
Ditto.
Attachment #8447024 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Changes since v1:
- comment #endif statement
Attachment #8447023 -
Attachment is obsolete: true
Attachment #8448771 -
Flags: review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Changes since v1:
- sort include statements alphabetically
Attachment #8447024 -
Attachment is obsolete: true
Attachment #8448772 -
Flags: review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f638a16ddbf7
https://hg.mozilla.org/mozilla-central/rev/91411f5b8574
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
You need to log in
before you can comment on or make changes to this bug.
Description
•