Closed
Bug 1031561
Opened 10 years ago
Closed 10 years ago
[B2G][Keyboard]Caps Lock is not always properly visually represented
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:2.0+, b2g-v1.4 affected, b2g-v2.0 verified, b2g-v2.0M verified, b2g-v2.1 verified)
People
(Reporter: rkuhlman, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(5 files)
There are two ways to set the keyboard into Caps Lock mode. If the user taps the shift key twice in a row, caps lock is turned on and visually represented by the shift key being underlined in blue and the shift icon glows blue. If the user taps the shift key once, types a letter, and taps the shift key again, Caps Lock will be engaged, but visually, it looks like the shift key has only been tapped once. The button is blue and the shift icon is white. Repro Steps: 1) Update a Flame to BuildID: 20140627040205 2) Launch Messaging app and start a new message. 3) Tap in compose text area. (Shift key should be highlighted by default) 4) Tap a single letter on the keyboard 5) Tap shift key again and observe visual state. (Caps Lock is enabled) 6) Type a few letters and hit spacebar. (Letters should all be capitalized) 7) Double tap shift key and observe visual state. 8) Compare shift key appearance from step 5 to appearance from step 7 Actual: Caps Lock indicator looks different depending on how caps lock is initiated Expected: Caps Lock is always visually represented in the same way Master M/C Environmental Variables: Device: Flame Master M/C MOZ BuildID: 20140627040205 Gaia: b8f36518696f3191a56e4f33447ee9d6ec820da1 Gecko: 9290d7995f98 Version: 33.0a1 Firmware Version: v122 Notes: Repro frequency: 100% See attached: logcat, screenshot
Reporter | ||
Comment 1•10 years ago
|
||
Attaching screenshot of issue
Reporter | ||
Comment 2•10 years ago
|
||
adding qawanted to determine if issue occurs on v1.4 and v2.0
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v1.4:
--- → ?
status-b2g-v2.0:
--- → ?
status-b2g-v2.1:
--- → affected
Flags: needinfo?(jmitchell)
Keywords: qawanted
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Comment 3•10 years ago
|
||
This bug repro's on: Flame 2.1 Master, Flame 2.0, Flame 1.4, Buri 2.1 Actual Results: Shift key gets an abnormal highlight. Environmental Variables: Device: Flame Master Build ID: 20140630063630 Gaia: bc3bbf42d2a606f6b7038881cff5ec3795fdf953 Gecko: 3b46de297f3f Version: 33.0a1 (Master) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Flame 2.0 Build ID: 20140630085228 Gaia: 564ab3935206a6979b317597020f47aebe8c80fe Gecko: 7974d58adda4 Version: 32.0a2 (2.0) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Flame 1.4 Build ID: 20140629211929 Gaia: aa896d5db1b4929f3bf31a0f4bb7de50530222a8 Gecko: 8cba60bc12ef Version: 30.0 (1.4) Firmware Version: v122 --------------------------------------------- Environmental Variables: Device: Buri Master Build ID: 20140630063630 Gaia: bc3bbf42d2a606f6b7038881cff5ec3795fdf953 Gecko: 3b46de297f3f Version: 33.0a1 (Master) Firmware Version: v1.2device.cfg
Comment 4•10 years ago
|
||
not a regression
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Assignee | ||
Comment 5•10 years ago
|
||
For the case 2, "If the user taps the shift key once, types a letter, and taps the shift key again", this is a feature that you could easily type acronym this way, and in my opinion, this is not in "Capslock" mode, since after your press [space] key, it would change back to lowercase. When in "Capslock" mode, after you press [space] key, the capslock mode will still be on, so you could continue to type in uppercase. I don't think there is an issue here, but I'll ask Omega, our keyboard UX, to double confirm we don't need to change the behavior.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(ofeng)
Comment 6•10 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #5) > For the case 2, "If the user taps the shift key once, types a letter, and > taps the shift key again", this is a feature that you could easily type > acronym this way, and in my opinion, this is not in "Capslock" mode, since > after your press [space] key, it would change back to lowercase. I think this feature confuses users. Let's remove it if there are no any other concerns.
Flags: needinfo?(ofeng)
Assignee | ||
Comment 8•10 years ago
|
||
This is a simple patch to remove a "feature" that sometimes confuses the tester. David, could you please help review this? Thank you.
Attachment #8463930 -
Flags: review?(dflanagan)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlu
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S1 (1aug)
Comment 9•10 years ago
|
||
Comment on attachment 8463930 [details]
Patch V1
I think it was kind of a cool feature. The main point was that if you move the cursor to edit a word that is in all caps, you'll automatically get all caps, which I thought was kind of nice.
But I agree that removing it is easier than trying to implement a true locked state.
Note that I did not actually run the code to test the patch.
Attachment #8463930 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/80a452a2615446839482ee98a0744285d723f531 -- David, thanks, I thought it was cool actually, but sorry to remove this per UX requirement.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Comment 14•10 years ago
|
||
Hi Rudy, can you request uplift this to 2.0? Thanks.
blocking-b2g: --- → 2.0+
Updated•10 years ago
|
Flags: needinfo?(rlu)
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8463930 [details] Patch V1 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): N/A, this is done by removing a confusing feature. [User impact] if declined: The user would not know why the keyboard keeps Capslocked when there are more than 2 uppercase letters in front. [Testing completed]: yes, unit test + manual test. [Risk to taking this patch] (and alternatives if risky): low, this stays on master for a while. [String changes made]: N/A
Attachment #8463930 -
Flags: approval-gaia-v2.0?
Flags: needinfo?(rlu)
Comment 16•10 years ago
|
||
Comment on attachment 8463930 [details]
Patch V1
Adding verifyme for QA to help verify this once it lands.
Attachment #8463930 -
Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
Assignee | ||
Comment 17•10 years ago
|
||
Seems this needs a v2.0-specific patch, so I created a pull request first, https://github.com/mozilla-b2g/gaia/pull/24469/files Waiting for CI result.
Keywords: branch-patch-needed
Comment 18•10 years ago
|
||
v2.0: https://github.com/mozilla-b2g/gaia/commit/d818e99094a119aebf7d0a9fa0db3e99b66f9046
Keywords: branch-patch-needed
Comment 19•10 years ago
|
||
v2.0m: https://github.com/mozilla-b2g/gaia/commit/256fcf95d088a05e66e59e4a1417542ca5ab8140
status-b2g-v2.0M:
--- → fixed
Comment 20•10 years ago
|
||
Verified it on latest v2.0 build. Cannot reproduce this bug. Attach the screenshot. (2014-10-06-19-04-58.png) * Build information: - Gaia 092d2b7678774c8b0b06dca0e0a8119e9eafdec3 - Gecko https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/69ca61f7edf3 - BuildID 20141006000202 - Version 32.0
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment 21•10 years ago
|
||
Comment 22•10 years ago
|
||
Verify passed, this issue can't be repro on Woodduck 2.0; Flame2.0&2.1. Attachment:Verify_Woodduck_Keyoard.MP4 Reproducing rate: 0/5 Woodduck 2.0 build: Gaia-Rev 60146ec47cd38a8be8ed22e0116902eceb9ac067 Gecko-Rev cdfbe9866cf0b71b33454926638ce0cd8bb1fb00 Build-ID 20141117050313 Version 32.0 Flame 2.0 build: Gaia-Rev 086a668942292168f312b3bb53e275fa0886fab1 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/a57b299c5cf2 Build-ID 20141116000206 Version 32.0 Flame2.1 build: Gaia-Rev 81160ad79e5b4c21967418dd63f1a1d08d77924e Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/3572aa3e6766 Build-ID 20141116001201 Version 34.0
Comment 23•10 years ago
|
||
Updated•10 years ago
|
QA Contact: croesch
You need to log in
before you can comment on or make changes to this bug.
Description
•