At the moment, cfx changes the entry point for an add-on when running tests to be `sdk/test/runner` instead of `lib/main.js`/`./index.js` when it writes the `harness-options.json` file, since jpm will not use this file, the entry point change should occur elsewhere, and the easiest solution I can see at the moment is to do this in `sdk/addon/runner`.

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/984e2ac115b7c335f5326a0b40f5fa11d32f0fca Bug 1031575 - change the add-on entry point in sdk/addon/runner instead of on the cfx/python side https://github.com/mozilla/addon-sdk/commit/a51d42a3292fbdb2a3adb15cb2a7616c5f38948d Merge pull request #1528 from erikvold/1031575 Bug 1031575 - change the add-on entry point in sdk/addon/runner instead of on the cfx/python side r=@jsantell

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/8b8d510b02cc96c8e0f2697a912348019304e012 Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner instead of on the cfx/python side" https://github.com/mozilla/addon-sdk/commit/9b37765c7a372d922803d7fd4089b62fe63d4c14 Merge pull request #1538 from mozilla/revert-1528-1031575 Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner ...

(In reply to [github robot] from comment #3) > Commits pushed to master at https://github.com/mozilla/addon-sdk > > https://github.com/mozilla/addon-sdk/commit/ > 8b8d510b02cc96c8e0f2697a912348019304e012 > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner > instead of on the cfx/python side" > > https://github.com/mozilla/addon-sdk/commit/ > 9b37765c7a372d922803d7fd4089b62fe63d4c14 > Merge pull request #1538 from mozilla/revert-1528-1031575 > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner ... Things are still broken for me even with this revert. Following code in sdk/self.js does not take into account that baseURI did not use to contain name before recent changes to this code: const baseURI = readPref("baseURI") || options.prefixURI + name + "/"; Addons out there still have preferences like the following: extensions.jid1-HE38Y6vsW9TpHg@jetpack.sdk.baseURI;resource://jid1-he38y6vsw9tphg-at-jetpack/ self.data.uri(path) is now broken for all of these addons. A migration from the old meaning of baseURI (not including name) is needed not to break existing addon-sdk addons.

(In reply to adrian from comment #4) > (In reply to [github robot] from comment #3) > > Commits pushed to master at https://github.com/mozilla/addon-sdk > > > > https://github.com/mozilla/addon-sdk/commit/ > > 8b8d510b02cc96c8e0f2697a912348019304e012 > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner > > instead of on the cfx/python side" > > > > https://github.com/mozilla/addon-sdk/commit/ > > 9b37765c7a372d922803d7fd4089b62fe63d4c14 > > Merge pull request #1538 from mozilla/revert-1528-1031575 > > > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner ... > > Things are still broken for me even with this revert. > > Following code in sdk/self.js does not take into account that baseURI did > not use to contain name before recent changes to this code: > > const baseURI = readPref("baseURI") || options.prefixURI + name + "/"; > > Addons out there still have preferences like the following: > > extensions.jid1-HE38Y6vsW9TpHg@jetpack.sdk.baseURI;resource://jid1- > he38y6vsw9tphg-at-jetpack/ > > self.data.uri(path) is now broken for all of these addons. > > A migration from the old meaning of baseURI (not including name) is needed > not to break existing addon-sdk addons. I'm not sure what bug you meant to put this comment in, but I doubt this is the one because the patch referenced here does not change affect the baseURI

(In reply to adrian from comment #4) > (In reply to [github robot] from comment #3) > > Commits pushed to master at https://github.com/mozilla/addon-sdk > > > > https://github.com/mozilla/addon-sdk/commit/ > > 8b8d510b02cc96c8e0f2697a912348019304e012 > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner > > instead of on the cfx/python side" > > > > https://github.com/mozilla/addon-sdk/commit/ > > 9b37765c7a372d922803d7fd4089b62fe63d4c14 > > Merge pull request #1538 from mozilla/revert-1528-1031575 > > > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner ... > > Things are still broken for me even with this revert. > > Following code in sdk/self.js does not take into account that baseURI did > not use to contain name before recent changes to this code: > > const baseURI = readPref("baseURI") || options.prefixURI + name + "/"; > > Addons out there still have preferences like the following: > > extensions.jid1-HE38Y6vsW9TpHg@jetpack.sdk.baseURI;resource://jid1- > he38y6vsw9tphg-at-jetpack/ > > self.data.uri(path) is now broken for all of these addons. > > A migration from the old meaning of baseURI (not including name) is needed > not to break existing addon-sdk addons. can you provide an example add-on?

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #5) > (In reply to adrian from comment #4) > > (In reply to [github robot] from comment #3) > > > Commits pushed to master at https://github.com/mozilla/addon-sdk > > > > > > https://github.com/mozilla/addon-sdk/commit/ > > > 8b8d510b02cc96c8e0f2697a912348019304e012 > > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner > > > instead of on the cfx/python side" > > > > > > https://github.com/mozilla/addon-sdk/commit/ > > > 9b37765c7a372d922803d7fd4089b62fe63d4c14 > > > Merge pull request #1538 from mozilla/revert-1528-1031575 > > > > > > Revert "Bug 1031575 - change the add-on entry point in sdk/addon/runner ... > > > > Things are still broken for me even with this revert. > > > > Following code in sdk/self.js does not take into account that baseURI did > > not use to contain name before recent changes to this code: > > > > const baseURI = readPref("baseURI") || options.prefixURI + name + "/"; > > > > Addons out there still have preferences like the following: > > > > extensions.jid1-HE38Y6vsW9TpHg@jetpack.sdk.baseURI;resource://jid1- > > he38y6vsw9tphg-at-jetpack/ > > > > self.data.uri(path) is now broken for all of these addons. > > > > A migration from the old meaning of baseURI (not including name) is needed > > not to break existing addon-sdk addons. > > I'm not sure what bug you meant to put this comment in, but I doubt this is > the one because the patch referenced here does not change affect the baseURI I didn't read the git log right. https://github.com/mozilla/addon-sdk/pull/1400 introduced the change in question, commit a660b25 specifically.

I wanted to try to take a look at this, but I'm not sure that I will be able to now.

Not sure if we need to do this after bug 1075541 is completed.