Closed
Bug 103189
Opened 23 years ago
Closed 13 years ago
::first-letter pseudo elements show no border property
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
WORKSFORME
mozilla1.2beta
People
(Reporter: mail, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: css1, regression, testcase, Whiteboard: [CSS1-2.4] (new bugs filled?))
Attachments
(3 files, 2 obsolete files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
text/html
|
Details |
Steps to reproduce:
1) Set border properties on first-letter pseudo element
Expected Bahvior:
1) Border around first-letter
Actual Behavior:
1) No Border is visible
This may be a regression. Builds as recent as 0.9.2 would show a border for
first-letter pseudo elements, but 0.9.4 does not. Testcase to follow
|
Reporter | |
Comment 1•23 years ago
|
||
|
||
Comment 3•23 years ago
|
||
This sounds like it's more likely to be a layout problem than style system.
|
||
Comment 4•23 years ago
|
||
99% sure this regressed with the rule tree landing. It worked in the 05-31
build, but not in the 06-01 build. Reassign to hyatt and putting [RULETREE] in
summary
Assignee: dbaron → hyatt
Summary: first-letter pseudo elements show no border property → [RULETREE?] first-letter pseudo elements show no border property
|
||
Comment 5•23 years ago
|
||
Oh boy oh boy oh boy!
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
|
|
||
Comment 6•23 years ago
|
||
Oh, there's code to do this intentionally in nsHTMLCSSStyleSheet. It just has
to be removed in the right way.
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.8
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.8 → mozilla0.9.9
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.2
|
||
Comment 7•23 years ago
|
||
What effect will this have on users of MachV?
|
||
Updated•23 years ago
|
Whiteboard: [CSS1-2.4]
|
||
Comment 8•23 years ago
|
||
Adding a "Dropped Initial" feature to Composer, I just discovered this bug too.
We don't draw borders on :first-letter.
IE and Opera don't have this bug. Konqueror has same bug.
|
|
||
Updated•23 years ago
|
Attachment #52082 -
Attachment description: testcase: set first-letter pseudo element to have a 1px black border → testcase: set first-letter pseudo element to have a 3px black border
|
|
||
Comment 9•23 years ago
|
||
This is a preliminary patch.
|
|
||
Comment 10•23 years ago
|
||
It might be a better solution if we did this work in nsRuleNode.cpp like we do
for :before and :after, though...
|
|
||
Comment 11•23 years ago
|
||
This one at least compiles and runs without assertions.
|
|
||
Comment 12•22 years ago
|
||
Taking the bug. This really needs to be a post-resolve callback, though.
Assignee: hyatt → dbaron
Status: ASSIGNED → NEW
Priority: -- → P2
Target Milestone: mozilla1.2alpha → mozilla1.1beta
|
|
||
Comment 13•22 years ago
|
||
And while I think of it, this should be fixed for XML documents too...
|
||
Comment 14•22 years ago
|
||
Also observed using FizzillaCFM/2002061014. Marking All/All.
OS: Windows 2000 → All
Hardware: PC → All
|
|
||
Updated•22 years ago
|
Target Milestone: mozilla1.1beta → mozilla1.2alpha
|
|
||
Updated•22 years ago
|
Whiteboard: [CSS1-2.4] → [CSS1-2.4][patch]
|
|
||
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → mozilla1.2beta
|
|
||
Comment 15•22 years ago
|
||
*** Bug 188654 has been marked as a duplicate of this bug. ***
|
|
||
Comment 16•22 years ago
|
||
Doing it in the post resolve callback or in ApplyStyleFixups will break if
someone does something like 'margin: inherit' and gets the struct from the
parent, unless we go through a lot of work. I think I'll just go with what I
have for now.
|
|
||
Comment 17•22 years ago
|
||
Basically just updated.
Attachment #82512 -
Attachment is obsolete: true
Attachment #84214 -
Attachment is obsolete: true
|
|
||
Updated•22 years ago
|
Attachment #113147 -
Flags: superreview?(bzbarsky)
Attachment #113147 -
Flags: review?(bzbarsky)
|
||
Comment 18•22 years ago
|
||
Comment on attachment 113147 [details] [diff] [review]
patch
+ // Disable everything in the Display struct except 'float' and
+ // 'clear'.
This should be moved down to just before the code that actually does it, no?
With that, looks good...
Attachment #113147 -
Flags: superreview?(bzbarsky)
Attachment #113147 -
Flags: superreview+
Attachment #113147 -
Flags: review?(bzbarsky)
Attachment #113147 -
Flags: review+
|
|
||
Comment 19•22 years ago
|
||
Fix checked in to trunk, 2003-02-22 11:20 PST. Still more work to be done here,
so leaving open, at least until I file a separate bug on the various issues
mentioned above.
|
|
||
Updated•22 years ago
|
Whiteboard: [CSS1-2.4][patch] → [CSS1-2.4]
|
||
Updated•21 years ago
|
Summary: [RULETREE?] first-letter pseudo elements show no border property → ::first-letter pseudo elements show no border property
Whiteboard: [CSS1-2.4] → [CSS1-2.4] (new bugs filled?)
|
|
||
Comment 20•20 years ago
|
||
What about those new bugs?
|
||
Comment 21•20 years ago
|
||
David, is this the case you mentioned in comment 16?
|
|
||
Updated•18 years ago
|
Assignee: dbaron → nobody
QA Contact: ian → style-system
|
||
Comment 22•18 years ago
|
||
Is there still something left to be done here?
|
||
Comment 23•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
The bug as reported is fixed.
Attachment 166811 [details] (comment 21) should be a seperate bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•