Closed
Bug 1031959
Opened 10 years ago
Closed 10 years ago
Add a_comment-end hook to show bug page
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: mail, Assigned: mail)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
This hook is used by Mozilla's Edit Comments extension, so it would be good to have it in the upstream code. All other eidt comment hooks already exist.
Attachment #8447781 -
Flags: review?(gerv)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8447781 [details] [diff] [review]
comment-v1.patch
Are you sure the current filename is the right second argument to the Hook.process() call? The docs:
http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Hook.html
suggest the second argument is a hash of parameters.
Gerv
|
Assignee | |
Comment 2•10 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #1)
> Are you sure the current filename is the right second argument to the
> Hook.process() call?
Yes.
> The docs:
> http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Hook.html
> suggest the second argument is a hash of parameters.
The above documentation relates to code Hook. The hook in my patch is a template hook. The documentation of template hooks is at: http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Template/Plugin/Hook.html
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8447781 [details] [diff] [review]
comment-v1.patch
r=gerv.
Gerv
Attachment #8447781 -
Flags: review?(gerv) → review+
|
|
||
Updated•10 years ago
|
Flags: approval?
|
|
Assignee | |
Comment 4•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
171e504..70b1cb4 master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: approval? → approval+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•