Just some things on the JS side that I ran into last week.

Comment on attachment 8448031 [details] [diff] [review] Patch Review of attachment 8448031 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi.cpp @@ -5645,5 @@ > if (!js_Stringify(cx, vp, replacer, space, sb)) > return false; > - if (sb.empty()) { > - HandlePropertyName null = cx->names().null; > - return callback(null->chars(), null->length(), data); I'm confused by this change; it seems unrelated to latin1.

(In reply to Luke Wagner [:luke] from comment #1) > I'm confused by this change; it seems unrelated to latin1. The problem is that cx->names().null is a Latin1 string ("null"), so we can't call chars() on it and we have to inflate to pass it to the callback. There are a number of ways to fix this; the patch just appends it to the StringBuffer so that there's only one call to the callback function.