The visibility APIs are standard APIs, we should really use those rather than the *FrameShow/Hide events that socialapi introduced. For the status panel, PanelFrame.jsm needs to be modified to set isActive=true in the popupshown event, and isActive=false in the popuphidden event. Setting isActive will cause the regular visibility API events to be sent.

Comment on attachment 8718653 [details] [diff] [review] remove custom shown/hidden events (use visibilityapi) Review of attachment 8718653 [details] [diff] [review]: ----------------------------------------------------------------- What's not to love about ripping code out :) I'm assuming you are taking care of the providers (lack of?) usage of this, so it LGTM.

move to review. chat window still provides these events, bug 1256431 is a followup for hello.

Comment on attachment 8730357 [details] [diff] [review] remove custom shown/hidden events (use visibilityapi) Review of attachment 8730357 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/socialchat.xml @@ +151,5 @@ > </getter> > <setter> > this.content.docShellIsActive = !!val; > > + // Bug 1256431 hello needs to use visibility api Can you please expand this comment - it wasn't obvious to me without looking at that bug. Something like "We still send these events for loop - bug xxx is to remove them" or something :)

https://hg.mozilla.org/integration/fx-team/rev/d9cc905f0f37faa8d1da6e449709d261eda4933b Bug 1032398 repalce socialShow/Hide with visibility api, r=markh