Closed
Bug 1032423
Opened 10 years ago
Closed 9 years ago
Move audiochannel stuff to be inner or outer window only
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1182316
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review-
|
Details | Diff | Splinter Review |
We really should move GetGlobalAudioVolume to be inner only, but I don't want to mess with the audiochannel code today.
Attachment #8448245 -
Flags: review?(bugs)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8448245 [details] [diff] [review]
Patch
As far as I see, GetAudioGlobalVolume is called with inner window too;
AudioChannelAgent is initialized with inner and then
AudioChannelAgent::GetWindowVolume calls GetAudioGlobalVolume.
So, MOZ_ASSERT(IsOuterWindow()); would fire.
Attachment #8448245 -
Flags: review?(bugs) → review-
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•