Description: When language is set to Swahili, the footer string "Auto-enhance on" appears cut-off on the Gallery edit page. This string is not cut-off in English. Repro Steps: 1) Update a Flame to 20140630000201 2) Change language to Swahili 3) Open Gallery app> Select a picture 4) Tap the edit icon> Turn Auto-enhance on 4) Observe Footer Actual: "Auto-enhance on" is cut-off at the bottom of the screen Expected: No strings are cut-off Environmental Variables: Device: Flame 2.0 Build ID: 20140630000201 Gaia: c0c8ad187c0466285f2580531e09f8322996f561 Gecko: d4dc609bcc8a Version: 32.0a2 (2.0) Firmware Version: v122 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Notes: Repro frequency: 3/3, 100% Link to failed test case: https://moztrap.mozilla.org/manage/case/12194/ See attached: screenshot

This issue does not occur on 1.4 Flame. Environmental Variables: Device: Flame 1.4 BuildID: 20140630000201 Gaia: aa896d5db1b4929f3bf31a0f4bb7de50530222a8 Gecko: 8cba60bc12ef Version: 30.0 (1.4) Firmware Version: v122 Swahili was not an available language.

User agent for 1.4: User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

This is missing a QAnalyst-Triage workflow

[Blocking Requested - why for this release]: Localizer tells us that there is no way to shorten this string. Swahili is a partner requested locale on 2.0 (see Mana). :ni on UX team to see if they have any suggestion on this one? Thanks!

This is a very old bug. Does this repro on 2.2?

Hey Stephany: partner wants to ship Swahili on 2.0, so this would have to get fixed on 2.0, if possible

Hi Stephany, and Stephen: Would you share more about UX's view for this issue in 2.0, also the reason to close this issue? Maybe we don't intent to fix it due to given 2.0 timing, and let partner to handle? Thanks.

Wesly, I do not know why the bug was closed; I did not close it, but Stephen did, and he cleared the needinfo? flag for UX, and I did not. I'm flagging Stephen to ask for more information on those decisions. I'm flagging Eric to see if he has any visual design advice on this.

(In reply to Stephany Wilkes from comment #8) > Wesly, I do not know why the bug was closed; I did not close it, but Stephen > did, and he cleared the needinfo? flag for UX, and I did not. I'm flagging > Stephen to ask for more information on those decisions. > > I'm flagging Eric to see if he has any visual design advice on this. Redirecting to Amy since she's the owner of Gallery. The quickest solution at this point would most likely be to reduce the font size or if there's space use 2 lines.

Hi, I just flashed the flame device to the latest build and it looks like it has been fixed (see screenshot).

Amy: did you flash to the latest 2.0 or master? Swahili is a partner request on 2.0, so we have to make sure this gets fixed on 2.0, not the latest build :)

(In reply to Delphine Lebédel [:delphine - use need info] from comment #11) > Amy: did you flash to the latest 2.0 or master? > Swahili is a partner request on 2.0, so we have to make sure this gets fixed > on 2.0, not the latest build :) Can we take the styling from the latest build and apply it to 2.0? That would fix this issue.

Hi Derek, Could you please help to check whether the fix on master per comment 10 is your expectation? Thanks!

Yeah this appears to be fixed on Flame 3.0 No strings are cut-off when turning on Auto-Enhance Environmental Variables: Device: Flame 3.0 Build ID: 20150305010212 Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452 Gecko: 56492f7244a9 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Hi, I am confused here. We need this fix to get into 2.0, since we're launching in 2.0. We know since comment 10 that this is fixed on master. So... does the issue still repro today on 2.0 (Derek, hot potatoe's on you :D)? If so, we'll need to get a fix in there. thanks!

This issue is also fixed on Flame 2.0 The edit icons are no longer overlapping the auto-enhance text. Note: The text is very close to the edge of the screen, as shown in the attached screenshot Environmental Variables: Device: Flame 2.0 (319mb)(Kitkat)(Full Flash) Build ID: 20150305000245 Gaia: 8eaa7ab64bc2c6fa882d6e16766f27ed89c86f34 Gecko: bd329de507c8 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 32.0 (2.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

(In reply to Derek Harris [:DerekH] from comment #16) > Created attachment 8573497 [details] > Swahili edge screenshot > > This issue is also fixed on Flame 2.0 > > The edit icons are no longer overlapping the auto-enhance text. > > Note: The text is very close to the edge of the screen, as shown in the > attached screenshot > > Environmental Variables: > Device: Flame 2.0 (319mb)(Kitkat)(Full Flash) > Build ID: 20150305000245 > Gaia: 8eaa7ab64bc2c6fa882d6e16766f27ed89c86f34 > Gecko: bd329de507c8 > Gonk: e7c90613521145db090dd24147afd5ceb5703190 > Version: 32.0 (2.0) > Firmware Version: v18D-1 > User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 I think we should fix this so the text is on 2 lines. I agree that the text is too close to the edge of the screen. Please refer to the screenshot in comment 10. Thanks

Hi Evelyn, is there anyone in your team can help on 2 lines? thanks.

Hi, We had a prolonged discussion as Swahili L10n team and this translation was the best we could come up with that also happens to fit in the screen although the words are too close to the edge. The phrase in English is so short. Compound words like auto-enhance are quite new words that have came up as technology advances thus it becomes very hard to have a Swahili word made up for such with the speed at which things are moving in the tech arena.

Gary, could you check which commit fixed the issue on master? and see if we could uplift it. Thanks!

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 Hi Punam, In order to fix this issue, I use 'p' instead of 'span'. Could you help to review this patch?! Thanks.

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 Hi Gary I am giving r- because with the attached PR a) We can apply the styles on containing div without updating span to p (see github) b) IMO Second line shows too close to bottom footer icons(should have bottom margin as seen in screen shot #comment 10). Since it's a UI change please attach screen shot to get ui-review with Amy. Latest master has edit UI flow updated in two steps and we are using building blocks for showing enhance banner, for 2.0 I will recommend simpler fix of keeping margin 1rem instead of breaking it in two lines and updating line-height and font-size to sizes we have in latest master i.e #edit-enhance-options { text-align: center; line-height: 2.2rem; font-size: 1.8rem; margin: 1rem; } Thanks!

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 Hi pdahiya, I've addressed your comment and also use 'margin 1rem', could you help to review this patch again? Thanks.

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 Thanks Gary, patch looks good. Setting ui-review flag for Amy to review updated Auto enhance message styles. Hi Amy, Image editing flow and code in 2.0 is different from latest master (which is two step edit - main edit screen and edit tools). It will not be a simple change to bring auto enhance message to two lines. I prefer the attached patch as it's fixing message showing too close to edge of screen by reducing font size similar to latest master. Please review (#comment 26). Thanks!

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 For some reason I don't see ui-review flag, using feedback flag for Amy's feedback.

(In reply to Punam Dahiya from comment #28) > Comment on attachment 8581421 [details] > [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 > > Thanks Gary, patch looks good. Setting ui-review flag for Amy to review > updated Auto enhance message styles. > > Hi Amy, > Image editing flow and code in 2.0 is different from latest master (which is > two step edit - main edit screen and edit tools). It will not be a simple > change to bring auto enhance message to two lines. > I prefer the attached patch as it's fixing message showing too close to edge > of screen by reducing font size similar to latest master. Please review > (#comment 26). Thanks! Hi, I looked at the attachment in comment 26 and the font being used doesn't look like Fira Sans and the spacing of some of the letters looks off. Can check to make sure the correct font is being used? Thanks

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 The font being used doesn't look like Fira Sans and the spacing between the letters look off (There is a gap in the word "Edit" in the header). For the next review can you attach a screenshot? Thanks

(In reply to Amy Lee [:amylee] from comment #30) > (In reply to Punam Dahiya from comment #28) > > Comment on attachment 8581421 [details] > > [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 > > > > Thanks Gary, patch looks good. Setting ui-review flag for Amy to review > > updated Auto enhance message styles. > > > > Hi Amy, > > Image editing flow and code in 2.0 is different from latest master (which is > > two step edit - main edit screen and edit tools). It will not be a simple > > change to bring auto enhance message to two lines. > > I prefer the attached patch as it's fixing message showing too close to edge > > of screen by reducing font size similar to latest master. Please review > > (#comment 26). Thanks! > > Hi, > > I looked at the attachment in comment 26 and the font being used doesn't > look like Fira Sans and the spacing of some of the letters looks off. Can > check to make sure the correct font is being used? Thanks Fonts on firefoxOs devices are controlled by gecko https://github.com/mozilla-b2g/moztt. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=987872#c97 for new Fira font uplift request to 2.0.

Hi Amy, I just update the font and attach screen shot, could you help to review the latest ui again? Thanks.

Comment on attachment 8587192 [details] screenshot20150402.jpg Hi, This looks good to me. Thanks

landed in v2.0 https://github.com/mozilla-b2g/gaia/commit/07e07b9376ac57b09810a34de25726602858e20a

Do we need this on v2.1/v2.2?

After checking v2.2[1] and v2.1[2] source code, I think only v2.1 was affected and need to uplift, v2.2 looks good and same as v3.0. Hi Ryan, But I am not sure do we need to get v2.1 approval first? If no could you help to uplift it? Thanks. [1] https://github.com/mozilla-b2g/gaia/blob/v2.2/apps/gallery/index.html#L214 [2] https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/gallery/index.html#L199

All uplifts need approval.

[Blocking Requested - why for this release]:

Blocking status isn't the same as approval. The approval request is made on the attachment.

I so confuse, do I need to get the v2.1+ first and then request v2.1 approval? Or just request v2.1 approval directly?

Just request approval :)

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 [Approval Request Comment] [Bug caused by] (feature/regressing bug #):regressing [User impact] if declined:text overflow when language set as Swahili. [Testing completed]: pass [Risk to taking this patch] (and alternatives if risky): low [String changes made]: N/A

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.0. See attachment: verified_v2.0.png Reproduce rate: 0/5 Device: Flame 2.0 build(Pass) Build ID 20150415160206 Gaia Revision 84898cadf28b1a1fcd03b726cff658de470282f0 Gaia Date 2015-04-03 21:42:36 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/bcbd45a97031 Gecko Version 32.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150415.192408 Firmware Date Wed Apr 15 19:24:17 EDT 2015 Bootloader L1TC000118D0

Comment on attachment 8581421 [details] [gaia] mpizza:Bug_1032441_v2.0 > mozilla-b2g:v2.0 Given this was taken on 2.0 recently, approving on 2.1 as well.

v2.1: https://github.com/mozilla-b2g/gaia/commit/7cd76434b58be2cfef7d23451e668c76591f05c3