Verdi [:verdi] Best to slack me Reporter
	Description • 10 years ago

In Firefox 32 we added a screen where the user can choose what to import (data from another browser, data from Firefox, or nothing/cancel). In previous versions, we don't provide this choice and just automatically import the Firefox data because that's how the feature was designed.

This new option causes a couple of problems:
1. This screen requires action on the user's part.
2. This screen has multiple (4-6) options with only 1 right choice (Firefox - the default). This invites the possibility of the user breaking the reset process and ending up with a blank profile which is explicitly not the purpose of the reset feature.

Video example of the difference: http://people.mozilla.org/~mverdi/video/reset-change.webm

We should remove this screen from the reset flow.

	Matthew N. [:MattN]
	Comment 1 • 10 years ago

This step has been in migration for a long time but something (maybe bug 705927?) broke the code to skip the first step for reset.

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 2 • 10 years ago

Does this impact 31 (beta)?

	:Gijs (he/him) Assignee
	Comment 3 • 10 years ago

(In reply to :Gijs Kruitbosch from comment #2)

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8288d0c7a15&tochange=62d33e3ba514

> June 6 - june 7, which per calendar is exactly in time for the 32 cutoff :'(
> . I'll doublecheck with beta in a second. I'll also continue bisecting
> because nothing in that backlog really jumps out at me...

	Matthew N. [:MattN]
	Comment 4 • 10 years ago

Some code links:
https://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp?rev=eabafb319aae&mark=3889#3882
https://mxr.mozilla.org/mozilla-central/source/toolkit/profile/nsIProfileMigrator.idl?rev=f4157e8c4107#62
https://mxr.mozilla.org/mozilla-central/source/browser/components/migration/MigrationUtils.jsm?mark=581-591&rev=f41a267983c1#554
https://mxr.mozilla.org/mozilla-central/source/browser/components/migration/content/migration.js?rev=875df781fa8b&mark=34-39,101-105#34

	:Gijs (he/him) Assignee
	Comment 5 • 10 years ago

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> 
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=c8288d0c7a15&tochange=62d33e3ba514
> 
> > June 6 - june 7, which per calendar is exactly in time for the 32 cutoff :'(
> > . I'll doublecheck with beta in a second. I'll also continue bisecting
> > because nothing in that backlog really jumps out at me...

This was wrong. New backlog:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cbe4f69c2e9c&tochange=e017c15325ae

there's several things in here... an asyncshutdown change and the window webidl switch...

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 6 • 10 years ago

Investigation completed, bug 1036186 has the fix (moved the tracking flags and such there).

	[SV Manager] Florin Mezei, QA (:FlorinMezei)
	Comment 7 • 10 years ago

Removing "qawanted" as it seems there's no more assistance needed from qa here.