Bruce Huang [:bhuang] (inactive) Reporter
	Description • 10 years ago

This story tracks the addition of a Bosnian keyboard.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 1 • 10 years ago

This is P1 since I think this is part of the product requirement.

	Bruce Huang [:bhuang] (inactive) Reporter
	Comment 2 • 10 years ago

Layout recommendation attached.  Jeff, is there someone that can help review it from l10n team? 
Thanks.

	Jeff Beatty [:gueroJeff]
	Comment 3 • 10 years ago

Passing this over to Kerim to review.

	Kerim Kalamujic
	Comment 4 • 10 years ago

Hey guys, I am happy to help!

The layout is all fine since QWERTZ is used for Bosnian language. As far as Long-Press Mappings are concerned, you can freely remove any mapped characters except for letters: c (č, ć); d (đ); s (š); z (ž). All other mapped characters are not from the Bosnian alphabet and thus aren't used in Bosnian language.

If there is anything else I can help out with, don't hesitate to ping me.

	bruce <bruhuang@gmail.com> Assignee
	Comment 5 • 10 years ago

Hi Rudy, added a Bosnian layout according to the attachment, can you help review?  Thanks.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 6 • 10 years ago

Comment on attachment 8469062 [details]
Bosnian keyboard layout

Looks good to me with some questions on the pull request, please help take a look.
Besides, we should add an entry to the following file,
"bs": [
        {"layoutId": "bs", "app": ["apps", "keyboard"]}
],
https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json#L20

Do we need a native speaker to do the ui review?

	Kerim Kalamujic
	Comment 7 • 10 years ago

Just let me know if you need me to review anything (I'm a native speaker).

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 8 • 10 years ago

Comment on attachment 8469062 [details]
Bosnian keyboard layout

Kerim,

Thanks! 
Could you please test this patch with simulator or device?
BTW, we would need your opinion on if "Bosanski" is a good native name for this layout.

	Kerim Kalamujic
	Comment 9 • 10 years ago

"Bosanski" is the right name for the layout. Can you please provide a bit more information on how I can test it on a device since I have a Keon phone with me.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 10 • 10 years ago

If you have built Gaia before, then you could do:
GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,pl,zh-Hans-Pinyin,en-Dvorak,bs make install-gaia
(Note that this would update the Gaia on you Keon, so if your Keon is for your own daily use, not for development, maybe you should try simulator instead of on device.)

and then you could enable this new layout for settings app > Keyboards > Select Keyboards.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 11 • 10 years ago

Bruce, I'll change the assignee since you've got a patch.
Thanks for your great work!

	bruce <bruhuang@gmail.com> Assignee
	Comment 12 • 10 years ago

(In reply to Rudy Lu [:rudyl] from comment #6)
> Comment on attachment 8469062 [details]
> Bosnian keyboard layout
> 
> Looks good to me with some questions on the pull request, please help take a
> look.
> Besides, we should add an entry to the following file,
> "bs": [
>         {"layoutId": "bs", "app": ["apps", "keyboard"]}
> ],
> https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-
> layouts.json#L20
> 
Updated pull request based on these comments.

	bruce <bruhuang@gmail.com> Assignee
	Comment 17 • 10 years ago

Kerim, I added some screenshots first while you work on trying the patch on device.  For the long press characters, I kept the ones in the layout recommendation since some users might want to type words in other languages without switching from the Bosnian layout.  So the alt characters are:
    c: 'čć'
    d: 'đ'
    e: 'ë€'
    i: 'íîïì'
    o: 'ó'
    u: 'ú'
    s: 'šş'
    z: 'ž'

	Kerim Kalamujic
	Comment 18 • 10 years ago

OK, Bruce. Should I patch the device or use the simulator? What do you suggest?

	bruce <bruhuang@gmail.com> Assignee
	Comment 19 • 10 years ago

As mentioned in comment 10, you can patch the device but it will update the Gaia on your device.  If your device is for development purpose it's fine, but if it's your daily phone then it'll be up to you whether you'll want to update Gaia since it may affect your day to day use.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 20 • 10 years ago

Kerim,

If you still could not review this on simulator, would you mind review this by taking a look at the screeshots?
Created attachment 8469121 [details]
Keyboard_1

Created attachment 8469124 [details]
Keyboard_2

Created attachment 8469125 [details]
Keyboard_3

Thanks.

	Kerim Kalamujic
	Comment 21 • 10 years ago

OK, I will not test on simulator. This looks good, but I didn't see an image for S -> Š. I hope it's there too.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 22 • 10 years ago

Hi Kerim,

Thanks for the review, this is the pop-up for 'S', please help take a look.

	Kerim Kalamujic
	Comment 23 • 10 years ago

Looking good. Go for it.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 24 • 10 years ago

Comment on attachment 8469062 [details]
Bosnian keyboard layout

ui-review+ from Kerim.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 25 • 10 years ago

This is ready to land.
Bruce, could you help do the squash, let me know if you need me to help.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 26 • 10 years ago

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/5cec5fef1aa2b320b0f07b7771d5f273aae18f0d

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 27 • 10 years ago

Don't we need a word list for spell checker for the language? Needinfo product to clarify.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 28 • 10 years ago

Bug 1050558 has been filed to track the suggestion part.

	Kerim Kalamujic
	Comment 29 • 10 years ago

Kevin and I are working on it.

	Bruce Huang [:bhuang] (inactive) Reporter
	Comment 30 • 10 years ago

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #27)
> Don't we need a word list for spell checker for the language? Needinfo
> product to clarify.

Yes, originally there was a question on whether we could directly leverage the Croatian word list, but that's being addressed in bug 1050558.

	Kerim Kalamujic
	Comment 31 • 10 years ago

Hey Gerry, what do you need from me? Frankly, not sure what this flag "in-moztrap" really is?

	Gerry Chang [:gchang]
	Comment 32 • 10 years ago

Hi Kerim, 
I re-mark "in-moztrap" as +, you just perform the normal tests for L10N in Bosnian including keyboard and language.

	Jason Smith [:jsmith]
	Comment 33 • 10 years ago

(In reply to Gerry Chang [:cfchang] from comment #32)
> Hi Kerim, 
> I re-mark "in-moztrap" as +, you just perform the normal tests for L10N in
> Bosnian including keyboard and language.

Gerry - If l10n is driving the testing here, then I would expect MozTrap test cases to be created, except I think it would be driven by Delphine specifically. We would use these MozTrap test cases during our l10n test run. As such, I think there are test cases we need to create here. Should we flag in-moztrap? to Delphine then?

	Gerry Chang [:gchang]
	Comment 34 • 10 years ago

Hi Jason,
I've talked this with William, according to William, L10N should choose the existing tests in moztrap as they usually do for other languages. 

Hi William,
Please correct me if I am wrong.

	William Hsu [:whsu]
	Comment 35 • 10 years ago

As I known, L10n team should pick i18n test case to verify the content/wording since we are not language expertise.
But, for QA, we can have a test case to make sure that Bosnian keyboard is ready for test.
Does it make sense?

@ Test case for QA:
  - https://moztrap.mozilla.org/manage/case/14403/

@ Test case for l10n team
  - https://moztrap.mozilla.org/manage/cases/?filter-suite=632

Thanks for the help! :)

	Gerry Chang [:gchang]
	Comment 36 • 10 years ago

After doing GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,fr-CA,pl,zh-Hans-Pinyin,en-Dvorak,bs make install-gaia, "Bosanski" is displayed in keyboard list.