Closed
Bug 1033825
Opened 10 years ago
Closed 10 years ago
[Contacts] Remove role="button" CSS selectors
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access)
Attachments
(1 file)
They are mostly stale, and we should not be styling with the accessibility role, this gives us no latitude to tweak the markup to be more friendly for screen readers.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8449863 -
Flags: review?(francisco)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8449863 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21310 Since I'm a bit overloaded I'm forwarding the review to Sergi, so this patch doesn't get obsolete. Thanks folks!
Attachment #8449863 -
Flags: review?(francisco) → review?(sergi.mansilla)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8449863 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21310 Looks good, thanks.
Attachment #8449863 -
Flags: review?(sergi.mansilla) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/b0e346f2f131e77e527058d3430bf519a789cc7c
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•