In order to start cutting xpcom's dependency on uconv, we should move all the unicode conversion nsILocalFile routines in nsLocalFileCommon.cpp out into a separate file in mozilla/xpcom/io. nsLocalFileMac.cpp aleady has code to do this with OS routines but this code can't be used because of where the methods are defined. If we split them out into another file, platforms which need it will link with that file, and those that don't, won't. As the other platforms implement the conversion natively, this file can can go away.

-> 0.9.6

Conrad, is this the same as http://bugzilla.mozilla.org/show_bug.cgi?id=100676 (which I haven't actually worked on)

It's a step towards that. The ultimate would be to eliminate all dependency on unconv from nsIFile. Doing that all at once would be a tough task which would require expertise on all platforms. This just makes it easier to divide and conquer.

The patch just moves the evil from one place to another - pretty simple. The new files can be removed from the build a platform at a time and then retired when the transition is complete. pete, alec, can you r/sr?

Comment on attachment 56166 [details] [diff] [review] patch sr=alecf

Doug - can I get r= on this?

Comment on attachment 56166 [details] [diff] [review] patch r=dougt if you remove tone down my old "E_V_I_L" comment. also, do you really want to have a header file nsLocalFileUnicode.h? Why not just extern it in the one place you call it? (maybe a nit that won't stand up with our style guidelines, but I do not like a NS_* function defined in a header file)

Comment on attachment 56166 [details] [diff] [review] patch r=dougt if you remove tone down my old "E_V_I_L" comment. also, do you really want to have a header file nsLocalFileUnicode.h? Why not just extern it in the one place you call it? (maybe a nit that won't stand up with our style guidelines, but I do not like a NS_* function defined in a header file)

Alright - I'll get rid of your old E_V_I_L comment and just explain in nicer terms why that code's there. I had the same question about a header file which contained only one function. But, since these files will only exist during a transition period and then be removed, and since the current patch has r=/sr=, I'll stick with it.

Mass move to 0.9.7

Checked in. Let the conversion to native unicode handling begin.