Closed
Bug 1033853
Opened 10 years ago
Closed 10 years ago
Unsaved files changes disappear when switching files in editor
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: wenzel, Assigned: bgrins)
References
Details
Attachments
(1 file)
(deleted),
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
STR:
- Start a new project from template
- click on manifest.webapp
- edit the name, but do not save
- click on a different file
- note: there's a * next to manifest.webapp to indicate it has unsaved changes
- click on manifest.webapp again
Actual:
- WebIDE reloads the file from disk (?), vaporizing your changes
Expected:
- though unsaved, merely clicking between different files to edit should not squash your edits.
Comment 1•10 years ago
|
||
Brian, I'm pretty sure this used to work. Must be a regression. Not sure if it's an itchpad or webide issue. Can you take a look?
Flags: needinfo?(bgrinstead)
Summary: Unsaved manifest changes disappear when switching files in editor → Unsaved files changes disappear when switching files in editor
Updated•10 years ago
|
Blocks: enable-webide
Assignee | ||
Comment 2•10 years ago
|
||
It's currently reloading files each time it is opened. We could not do so if the file has changes.
When we have file watching set up we could handle the case more gracefully, by only reloading if the file has changed and to also prompt the user if the file has changed both on disk and in the editor.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8451649 -
Flags: review?(fayearthur)
Comment 4•10 years ago
|
||
Comment on attachment 8451649 [details] [diff] [review]
changed-files-reload.patch
Review of attachment 8451649 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8451649 -
Flags: review?(fayearthur) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•10 years ago
|
QA Whiteboard: [good first verify]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•