Closed
Bug 1033935
Opened 10 years ago
Closed 9 years ago
Enable MediaCodecReader by default.
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
INVALID
2.2 S5 (6feb)
People
(Reporter: brsun, Assigned: bechen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
This is a followup bug of bug 904177. MediaCodecReader should be enabled only after all the existing capability of MediaOmxReader have been integrated in it.
Reporter | ||
Updated•10 years ago
|
Blocks: b2g-multimedia
Comment 1•10 years ago
|
||
mark feature-b2g: 2.2? to review if we can make it on v2.2.
feature-b2g: --- → 2.2?
Flags: needinfo?(bechen)
Updated•10 years ago
|
Assignee: nobody → bechen
Updated•10 years ago
|
Target Milestone: --- → 2.2 S5 (6feb)
Assignee | ||
Comment 3•10 years ago
|
||
push to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b2f437a041
Flags: needinfo?(bechen)
Assignee | ||
Comment 4•10 years ago
|
||
According to the log: https://hg.mozilla.org/mozilla-central/filelog/940118b1adcd/dom/media/omx/MediaCodecReader.cpp Bug 1114910, Bug 1118632, Bug 1120247, Bug 1091467, these 4 patches and need to uplift to 2.2 .
Comment 5•10 years ago
|
||
(In reply to Benjamin Chen [:bechen] from comment #3) > push to try: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b2f437a041 Tryserver does not do actual testing for MediaCodec. Current tryserver do actual testing only on ICS on gonk. And MediaCodec is supported since JB. Therefore, if MediaCodec is enabled as default. It's capability is not tested on tryserver :-(
Comment 6•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #5) > Tryserver does not do actual testing for MediaCodec. Current tryserver do > actual testing only on ICS on gonk. And MediaCodec is supported since JB. > Therefore, if MediaCodec is enabled as default. It's capability is not > tested on tryserver :-( Yes, jlal's team is trying to get emulator-kk auto-testing online. We should able to test MediaCodec after that.
Comment 7•10 years ago
|
||
Set bug 1107678 as blocker to make sure we have automatic testing on try server.
Depends on: 1107678
Comment 9•10 years ago
|
||
(In reply to StevenLee[:slee] from comment #7) > Set bug 1107678 as blocker to make sure we have automatic testing on try > server. Nice!
Comment 10•10 years ago
|
||
Comment on attachment 8558425 [details] [diff] [review] enableMediaCodec.patch Review of attachment 8558425 [details] [diff] [review]: ----------------------------------------------------------------- reivew+ if bug 1107678 is fixed.
Attachment #8558425 -
Flags: review?(sotaro.ikeda.g) → review+
Comment 11•10 years ago
|
||
The change might have some regression risks. One regression risk is power consumption during pause.
Comment 12•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #11) > The change might have some regression risks. One regression risk is power > consumption during pause. yes. IIRC, that regression is only on CAF platform. IMHO, we should try to avoid having this platform specific power saving mechanism as possible as we can. Extending our dormant mechanism might be a more generic and cross-platform solution on power saving.
Comment 14•10 years ago
|
||
Do we know why this fix has not yet landed on v2.2? AFAICT, it has all the approvals for a while.
Comment 15•10 years ago
|
||
This bug is for MediaCodec usage for media playback. It is not related to video recording via mozCamera API.
Updated•9 years ago
|
Component: Audio/Video → Audio/Video: Playback
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•